You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/27 04:52:12 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #4956: [Refactor] Private constructor for singleton

morningman commented on a change in pull request #4956:
URL: https://github.com/apache/incubator-doris/pull/4956#discussion_r531381452



##########
File path: fe/fe-core/src/main/java/org/apache/doris/service/ExecuteEnv.java
##########
@@ -42,11 +43,6 @@ public static ExecuteEnv getInstance() {
         return INSTANCE;
     }
 
-    public static void setup() {
-        ExecuteEnv env = getInstance();
-        env.scheduler = new ConnectScheduler(Config.qe_max_connection);
-    }
-
     public ConnectScheduler getScheduler() {

Review comment:
       If you do this, then the `getScheduler()` and `getMultiLoadMgr()` need to be changed too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org