You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/05 15:31:12 UTC

[GitHub] [incubator-nuttx-apps] rurtle opened a new pull request #464: Fix for sim:mount selftest failure

rurtle opened a new pull request #464:
URL: https://github.com/apache/incubator-nuttx-apps/pull/464


   ## Summary
   
   Fix for NuttX [issue # 2089](https://github.com/apache/incubator-nuttx/issues/2089).
   
   ## Impact
   
   Ideally, this should fix the selftest issue for sim:mount configuration. Selftest should now complete without any errors.
   
   Changed g_target to g_mntdir as g_target and g_testdir4 are on the same filesystem.
   
   `fail_rename(g_mntdir, g_testdir4, EXDEV);`
   
   Also, changed error type `EEXIST` to `ENOENT` for the second `fail_rename()` call.
   
   ## Testing
   
   To be tested for sim:mount configuration. Ideally, the test should now run without any issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #464: Fix for sim:mount selftest failure

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #464:
URL: https://github.com/apache/incubator-nuttx-apps/pull/464#issuecomment-722777467


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #464: Fix for sim:mount selftest failure

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #464:
URL: https://github.com/apache/incubator-nuttx-apps/pull/464#issuecomment-723487655


   Thank you @rurtle for looking into and fixing these issues, it is super helpful.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #464: Fix for sim:mount selftest failure

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #464:
URL: https://github.com/apache/incubator-nuttx-apps/pull/464


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org