You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "CTTY (via GitHub)" <gi...@apache.org> on 2026/06/23 23:12:18 UTC

[PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

CTTY opened a new pull request, #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - release tracking issue: #2527 
   
   ## What changes are included in this PR?
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   ## Are these changes tested?
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700#discussion_r3470494727


##########
dev/release/dependencies.sh:
##########
@@ -100,7 +105,26 @@ require_cargo_deny() {
   require_command cargo
   if ! cargo deny --version >/dev/null 2>&1; then
     echo "This script requires 'cargo-deny' for dependency license checks." >&2
-    echo "Install it with: cargo install cargo-deny" >&2
+    echo "Install it with: cargo install --locked cargo-deny@${EXPECTED_CARGO_DENY_VERSION}" >&2
+    return 1
+  fi
+
+  # The TSV output is sensitive to the cargo-deny version: different versions
+  # resolve the dependency graph differently, producing diffs that CI rejects.
+  # Assert the active binary matches the version CI pins so a shadowed or
+  # mismatched install fails loudly instead of generating wrong files.
+  local actual_version
+  actual_version="$(cargo deny --version | awk '{print $2}')"
+  if [ "${actual_version}" != "${EXPECTED_CARGO_DENY_VERSION}" ]; then
+    echo "ERROR: cargo-deny version mismatch." >&2
+    echo "  expected: ${EXPECTED_CARGO_DENY_VERSION} (pinned by CI)" >&2
+    echo "  found:    ${actual_version} ($(command -v cargo-deny))" >&2
+    echo "" >&2
+    echo "Install the pinned version with:" >&2
+    echo "  cargo install --locked cargo-deny@${EXPECTED_CARGO_DENY_VERSION}" >&2
+    echo "" >&2
+    echo "If multiple cargo-deny binaries are installed, 'which -a cargo-deny'" >&2
+    echo "shows which one is shadowing the others on your PATH." >&2

Review Comment:
   Added this check to avoid silent failure when running cargo-deny locally due to local-expected cargo-deny version mismatch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700#issuecomment-4784844715

   The security audit failed, I've created another PR to fix it #2703 . Will rebase after the security fix is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY merged PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700#discussion_r3471500486


##########
dev/release/dependencies.sh:
##########
@@ -19,6 +19,11 @@
 
 set -Eeuo pipefail
 
+# Keep this in sync with CARGO_DENY_VERSION in .github/workflows/dependencies.yml.

Review Comment:
   Good point! I think we can update the dependencies.sh to take another arg, and have dependencies.yml to pass the version in. 
   
   We can create a separate PR to address this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700#discussion_r3471500486


##########
dev/release/dependencies.sh:
##########
@@ -19,6 +19,11 @@
 
 set -Eeuo pipefail
 
+# Keep this in sync with CARGO_DENY_VERSION in .github/workflows/dependencies.yml.

Review Comment:
   Good point! I think we can update the dependencies.sh to take another arg, and have dependencies.yml to pass the version in. 
   
   We can create a separate PR to address this: #2708 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700#discussion_r3470494727


##########
dev/release/dependencies.sh:
##########
@@ -100,7 +105,26 @@ require_cargo_deny() {
   require_command cargo
   if ! cargo deny --version >/dev/null 2>&1; then
     echo "This script requires 'cargo-deny' for dependency license checks." >&2
-    echo "Install it with: cargo install cargo-deny" >&2
+    echo "Install it with: cargo install --locked cargo-deny@${EXPECTED_CARGO_DENY_VERSION}" >&2
+    return 1
+  fi
+
+  # The TSV output is sensitive to the cargo-deny version: different versions
+  # resolve the dependency graph differently, producing diffs that CI rejects.
+  # Assert the active binary matches the version CI pins so a shadowed or
+  # mismatched install fails loudly instead of generating wrong files.
+  local actual_version
+  actual_version="$(cargo deny --version | awk '{print $2}')"
+  if [ "${actual_version}" != "${EXPECTED_CARGO_DENY_VERSION}" ]; then
+    echo "ERROR: cargo-deny version mismatch." >&2
+    echo "  expected: ${EXPECTED_CARGO_DENY_VERSION} (pinned by CI)" >&2
+    echo "  found:    ${actual_version} ($(command -v cargo-deny))" >&2
+    echo "" >&2
+    echo "Install the pinned version with:" >&2
+    echo "  cargo install --locked cargo-deny@${EXPECTED_CARGO_DENY_VERSION}" >&2
+    echo "" >&2
+    echo "If multiple cargo-deny binaries are installed, 'which -a cargo-deny'" >&2
+    echo "shows which one is shadowing the others on your PATH." >&2

Review Comment:
   Added this check to avoid silent failure when running cargo-deny locally due to version mismatch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump version to 0.10.0, update changelog [iceberg-rust]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2700:
URL: https://github.com/apache/iceberg-rust/pull/2700#discussion_r3471093037


##########
dev/release/dependencies.sh:
##########
@@ -19,6 +19,11 @@
 
 set -Eeuo pipefail
 
+# Keep this in sync with CARGO_DENY_VERSION in .github/workflows/dependencies.yml.

Review Comment:
   maybe we can merge the versioning somehow, or add a comment in `.github/workflows/dependencies.yml` to point back to ehre



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org