You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zonghaishang (GitHub)" <gi...@apache.org> on 2018/12/17 02:37:45 UTC

[GitHub] [incubator-dubbo] zonghaishang opened issue #2980: Remove check rule CustomImportOrder

- [x] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.0
* Operating System version: mac
* Java version: 1.8

```
        <module name="CustomImportOrder">
            <property name="specialImportsRegExp" value="org.apache.dubbo.*"/>
            <property name="sortImportsInGroupAlphabetically" value="false"/>
            <property name="customImportOrderRules" value="SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE###STATIC"/>
        </module>
```

should be removed from `checkstyle.xml` ?

1. The original checkstyle automatically adjusts the import order.
2. This rule is very easy to cause ci to fail, development experience is not good.
3. Most importantly, is it meaningful to limit the import order?


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2980 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] beiwei30 closed issue #2980: Remove check rule CustomImportOrder

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ issue closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2980 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org