You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/07/31 22:23:45 UTC
[GitHub] [systemds] kev-inn opened a new pull request, #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
kev-inn opened a new pull request, #1643:
URL: https://github.com/apache/systemds/pull/1643
# `DoubleVector` replacement for matrix multiply
JDK 17 adds `Vector` classes to use SIMD instructions. This PR replaces the basic dense dense matrix multiply with an equivalent `DoubleVector` implementation. It is necessary to use JDK 17, therefore we should not merge this yet, but keep it in staging for future reference.
As an experiment we check a simple matrix multiply:
`Z = X %*% Y`, $X\in \mathbb{R}^{n\times k}, Y\in \mathbb{R}^{k\times m}$
The experiment script performs 10 matrix multiplications and saves the time of the last 5 to give the JVM some time to optimize.
## Vary rows n, m fixed at 1000
### Alpha Node
| $k = 1000$ | $k = 10000$ |
| --------------- | --------------- |
|  |  |
### Lima Node
| $k = 1000$ | $k = 10000$ |
| --------------- | --------------- |
|  |  |
## Vary cols m, n fixed at 1000
### Alpha Node
| $k = 1000$ | $k = 10000$ |
| --------------- | --------------- |
|  |  |
### Lima Node
| $k = 1000$ | $k = 10000$ |
| --------------- | --------------- |
|  |  |
## Conclusion
The implementation seems to boost the performance in most cases. The case where we vary the number of columns n on the alpha node needs some more exploration, but it seems we are never worse than the current implementation.
## Experiment Script
```R
X = read($Xfname);
Y = read($Yfname);
lim = 10;
R = matrix(0, rows=lim, cols=1);
for (i in 1:lim) {
t1 = time();
Z = X %*% Y;
t2 = time();
R[i,1] = (t2-t1)/1000000;
}
print(sum(Z));
res = R[5:lim,];
write(res, $fname, format="csv", sep="\t");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] kev-inn commented on pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
kev-inn commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1161407309
> What if you use some of the other experimental JVM that should have better support ?
Which ones do you have in mind, and what kind of support do you expect (which the current does not support)? To clarify, do you expect better performance or that we can remove the `--add-modules=jdk.incubator.vector` flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1643: Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1160904752
What if you use some of the other experimental JVM that should have better support ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
URL: https://github.com/apache/systemds/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1643: Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1160834039
This looks pretty good. I think Alpha has wider SIMD registers, which explains why most configurations perform better in Alpha.
Is there any JVM flag that you needed to enable? If so, can you please mention those as well for documentation purposes? @kev-inn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] kev-inn commented on pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
kev-inn commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1200495480
Closed by 9bf0a9fd9a64264301b0fc9310d6d9f976780870 (messed up the commit message)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] kev-inn commented on pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
kev-inn commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1200493306
# More experiments
Dump of more experiments and updated plots.
All in all the results look promising, but we can also clearly some of the weak spots.
## Alpha
### Variable columns
### Variable rows
## Lima
### Variable columns
### Variable rows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1164475133
> > What if you use some of the other experimental JVM that should have better support ?
>
> Which ones do you have in mind, and what kind of support do you expect (which the current does not support)? To clarify, do you expect better performance or that we can remove the `--add-modules=jdk.incubator.vector` flag?
Project Panama: https://openjdk.java.net/projects/panama/
And JDK 19 have the official full support for vectorizing; https://openjdk.org/jeps/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] kev-inn closed pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
kev-inn closed pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
URL: https://github.com/apache/systemds/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] kev-inn commented on pull request #1643: [SYSTEMDS-3393] Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
kev-inn commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1172137748
I ran the experiments again with jdk-19 (early access).
It seems to still require the same additional flags and still is part of the incubator module. This might be due to the early access version.
Results are similar, with the addition of sometimes one single iteration, of our sample, taking ~3-4x the time. Probably due to GC. This already existed before though and was introduced in my last commit. Or maybe I just got lucky in my first run, before the second commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] kev-inn commented on pull request #1643: Implement SIMD usage for basic dense dense MM
Posted by GitBox <gi...@apache.org>.
kev-inn commented on PR #1643:
URL: https://github.com/apache/systemds/pull/1643#issuecomment-1160853048
> This looks pretty good. I think Alpha has wider SIMD registers, which explains why most configurations perform better in Alpha. Is there any JVM flag that you needed to enable? If so, can you please mention those as well for documentation purposes? @kev-inn
Note the varying columns case for Alpha though, Lima is faster with `DoubleVector` than Alpha. I will take a closer look why that might be.
Yes, the flag is `--add-modules=jdk.incubator.vector`, which has to be added when running systemds (see the `systemds` script).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org