You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/22 04:57:22 UTC

[GitHub] [dolphinscheduler-website] SbloodyS opened a new pull request #747: [Feature][e2e] Suggest e2e test adapt M1 chip

SbloodyS opened a new pull request #747:
URL: https://github.com/apache/dolphinscheduler-website/pull/747


   Related pr:
   https://github.com/apache/dolphinscheduler/pull/9077
   https://github.com/apache/dolphinscheduler/issues/9068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #747: [Feature][e2e] Suggest e2e test adapt M1 chip

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #747:
URL: https://github.com/apache/dolphinscheduler-website/pull/747#discussion_r831790758



##########
File path: development/en-us/e2e-test.md
##########
@@ -177,9 +177,15 @@ The rest are similar cases and can be understood by referring to the specific so
 https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases
 
 ##  III. Supplements
+When running E2E tests locally, First, you need to start the local service, you can refer to this page: 

Review comment:
       Could you add one blank line after title?

##########
File path: development/en-us/e2e-test.md
##########
@@ -177,9 +177,15 @@ The rest are similar cases and can be understood by referring to the specific so
 https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases
 
 ##  III. Supplements
+When running E2E tests locally, First, you need to start the local service, you can refer to this page: 

Review comment:
       Same as zh docs. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #747: [Feature][e2e] Suggest e2e test adapt M1 chip

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #747:
URL: https://github.com/apache/dolphinscheduler-website/pull/747


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] SbloodyS commented on a change in pull request #747: [Feature][e2e] Suggest e2e test adapt M1 chip

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on a change in pull request #747:
URL: https://github.com/apache/dolphinscheduler-website/pull/747#discussion_r831792345



##########
File path: development/en-us/e2e-test.md
##########
@@ -177,9 +177,15 @@ The rest are similar cases and can be understood by referring to the specific so
 https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases
 
 ##  III. Supplements
+When running E2E tests locally, First, you need to start the local service, you can refer to this page: 

Review comment:
       I'' add it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org