You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liu-zhaokun <gi...@git.apache.org> on 2017/04/26 07:18:22 UTC
[GitHub] spark pull request #17769: [SPARK-20467] sbt-launch-lib.bash has lacked the ...
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/spark/pull/17769
[SPARK-20467] sbt-launch-lib.bash has lacked the ASF header.
[https://issues.apache.org/jira/browse/SPARK-20467](https://issues.apache.org/jira/browse/SPARK-20467)
When I use this script,I found sbt-launch-lib.bash lack the ASF header.It doesn't be permitted by Apache Foundation according to apache license 2.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liu-zhaokun/spark master_sbt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17769.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17769
----
commit 5f6941ad7cac371411fb573b1df29f73a98594de
Author: liuzhaokun <li...@zte.com.cn>
Date: 2017-04-26T07:16:51Z
[SPARK-20467] sbt-launch-lib.bash has lacked the ASF header.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17769: [SPARK-20467] sbt-launch-lib.bash has lacked the ASF hea...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17769
No, it's not a file created by this project. It's from https://github.com/sbt/sbt-launcher-package/blob/master/src/universal/bin/sbt-launch-lib.bash and its license is handled correctly already in the licenses/ folder. We cannot add the ASF header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17769: [SPARK-20467] sbt-launch-lib.bash has lacked the ...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/spark/pull/17769
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17769: [SPARK-20467] sbt-launch-lib.bash has lacked the ASF hea...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17769
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17769: [SPARK-20467] sbt-launch-lib.bash has lacked the ASF hea...
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/17769
@srowen
Thanks for your reply.I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org