You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/05 14:23:11 UTC

[GitHub] [cloudstack] rhtyd opened a new pull request #4202: server: don't export APIs if feature is not enabled in any zones

rhtyd opened a new pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202


   This change will ensure that B&R APIs are not exported if the feature is not enabled in any of the zones.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-653898269


   @blueorangutan test 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654606430


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654646323


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-653898372


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#discussion_r450078038



##########
File path: api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
##########
@@ -38,7 +38,7 @@
     ConfigKey<Boolean> BackupFrameworkEnabled = new ConfigKey<>("Advanced", Boolean.class,
             "backup.framework.enabled",
             "false",
-            "Is backup and recovery framework enabled.", true, ConfigKey.Scope.Zone);
+            "Is backup and recovery framework enabled. Restart management server on global value change.", true, ConfigKey.Scope.Zone);

Review comment:
       Fixed thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-653915694


   <b>Trillian test result (tid-1994)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 7573 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4202-t1994-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_backup_recovery_dummy.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 28 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDummyBackupAndRecovery>:setup | `Error` | 0.00 | test_backup_recovery_dummy.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654123922


   @davidjumani please review this, thnx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654606736


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654120020


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#discussion_r449932428



##########
File path: api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
##########
@@ -38,7 +38,7 @@
     ConfigKey<Boolean> BackupFrameworkEnabled = new ConfigKey<>("Advanced", Boolean.class,
             "backup.framework.enabled",
             "false",
-            "Is backup and recovery framework enabled.", true, ConfigKey.Scope.Zone);
+            "Is backup and recovery framework enabled. Restart management server on global value change.", true, ConfigKey.Scope.Zone);

Review comment:
       According to the description, ADMIN needs to restart the management server and therefore this is not a dynamic setting. 
   
   What do you think of changing the `isDynamic` param to `false`?
   
   _ConfigKey constructor:_
   ```
   public ConfigKey(String category, Class<T> type, String name, String defaultValue, String description, boolean isDynamic, Scope scope) {
       this(type, name, category, defaultValue, description, isDynamic, scope, null);
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654618015


   Packaging result: ✔centos7 ✔debian. JID-1539


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654646031


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-653895215


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#discussion_r450072471



##########
File path: api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
##########
@@ -38,7 +38,7 @@
     ConfigKey<Boolean> BackupFrameworkEnabled = new ConfigKey<>("Advanced", Boolean.class,
             "backup.framework.enabled",
             "false",
-            "Is backup and recovery framework enabled.", true, ConfigKey.Scope.Zone);
+            "Is backup and recovery framework enabled. Restart management server on global value change.", true, ConfigKey.Scope.Zone);

Review comment:
       I'll change that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654104943


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-653898200


   Packaging result: ✔centos7 ✔debian. JID-1534


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654742878


   Packaging result: ✔centos7 ✔debian. JID-1547


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654517165


   <b>Trillian test result (tid-2008)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49880 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4202-t2008-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_backup_recovery_dummy.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDummyBackupAndRecovery>:setup | `Error` | 0.00 | test_backup_recovery_dummy.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 470.84 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3853.05 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-653895140


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654119664


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export B&R APIs if feature is not enabled globally

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654839671


   Tested on KVM env, it skips tests for dummy provider now:
   ```
   Import provider backup offering from Dummy Backup and Recovery Provider ... SKIP: Skipping test cases which must only run for Simulator
   Test VM backup lifecycle ... SKIP: Skipping test cases which must only run for Simulator
   
   ----------------------------------------------------------------------
   Ran 2 tests in 0.124s
   
   OK (SKIP=2)
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654119285


   Packaging result: ✔centos7 ✔debian. JID-1536


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export APIs if feature is not enabled in any zones

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4202:
URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654105234


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org