You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/15 20:04:06 UTC

[GitHub] [spark] ueshin commented on a change in pull request #34608: [SPARK-37338] Rename (Spark)DataFrame.to_pandas_on_spark to (Spark)DataFrame.pandas_api

ueshin commented on a change in pull request #34608:
URL: https://github.com/apache/spark/pull/34608#discussion_r749643160



##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -3198,7 +3198,7 @@ def writeTo(self, table: str) -> DataFrameWriterV2:
         """
         return DataFrameWriterV2(self, table)
 
-    def to_pandas_on_spark(
+    def pandas_api(

Review comment:
       We can't just rename the API because we already have a release.
   We should keep or deprecate the original function and add the new API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org