You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/01 05:51:45 UTC
[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14331
Change subject: TestKuduPartitioner: deflake testBuildTimeout
......................................................................
TestKuduPartitioner: deflake testBuildTimeout
I saw a RELEASE build where the time taken by KuduPartitionerBuilder.build()
exceeded 110% of the timeout value. This was anticipated in code review[1],
but instead of removing this part of the test altogether, let's just make it
more lenient.
1. https://gerrit.cloudera.org/c/12275/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java#192
Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/14331/1
--
To view, visit http://gerrit.cloudera.org:8080/14331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
Gerrit-Change-Number: 14331
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14331 )
Change subject: TestKuduPartitioner: deflake testBuildTimeout
......................................................................
Patch Set 2: Verified+1
Failures are unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/14331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
Gerrit-Change-Number: 14331
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:05:54 +0000
Gerrit-HasComments: No
[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14331 )
Change subject: TestKuduPartitioner: deflake testBuildTimeout
......................................................................
TestKuduPartitioner: deflake testBuildTimeout
I saw a RELEASE build where the time taken by KuduPartitionerBuilder.build()
exceeded 110% of the timeout value. This was anticipated in code review[1],
but instead of removing this part of the test altogether, let's just make it
more lenient.
1. https://gerrit.cloudera.org/c/12275/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java#192
Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
Reviewed-on: http://gerrit.cloudera.org:8080/14331
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
Gerrit-Change-Number: 14331
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: TestKuduPartitioner: deflake testBuildTimeout
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
Gerrit-Change-Number: 14331
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] TestKuduPartitioner: deflake testBuildTimeout
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14331 )
Change subject: TestKuduPartitioner: deflake testBuildTimeout
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e734eb8321b6633d1999e2dd031d355ce299b86
Gerrit-Change-Number: 14331
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 04:08:39 +0000
Gerrit-HasComments: No