You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:57 UTC
[Impala-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
Hello Internal Jenkins, Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4251
to review the following change.
Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
......................................................................
IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
The /memz page tried to add JVM metrics even when they didn't exist for
all daemons, not just Impala. This led to a crash when they tried to
access ExecEnv::GetInstance() without an initialised ExecEnv at
statestored and catalogd
To fix, changed the memz handler method to take an optional metric
group, provided by the caller. memz handler will check the existence of
the metric group.
Used C++11 lambdas rather than boost::bind to help simplify the code.
Testing: Ran locally and looked at impalad/memz, statestored/memz
and catalogd/memz
Add a test file test_web_pages.py to test sending request to /memz on
impalad / statestored / catalogd
Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29
Reviewed-on: http://gerrit.cloudera.org:8080/3998
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 1fc487c7dfab862ca88a8f6ae7790e3b004756a8)
---
M be/src/catalog/catalogd-main.cc
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestored-main.cc
M be/src/util/default-path-handlers.cc
M be/src/util/default-path-handlers.h
M be/src/util/memory-metrics.cc
M be/src/util/metrics-test.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
A tests/webserver/test_web_pages.py
M www/memz.tmpl
15 files changed, 96 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/51/4251/1
--
To view, visit http://gerrit.cloudera.org:8080/4251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Kathy Sun <ka...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Kathy Sun <ka...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>