You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by thomasmey <gi...@git.apache.org> on 2017/01/27 21:32:50 UTC
[GitHub] commons-compress pull request #16: Don't duplicate count() functionality.
GitHub user thomasmey opened a pull request:
https://github.com/apache/commons-compress/pull/16
Don't duplicate count() functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thomasmey/commons-compress work/misc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit f71a4cd326eff69b42ed4860d8359af4df1d2ecf
Author: Thomas Meyer <th...@m3y3r.de>
Date: 2017-01-27T17:36:01Z
Don't duplicate count() functionality.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #16: Don't duplicate count() functionality.
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/16
True, a unit-test wouldn't hurt.
I'm afraid I can't close the PR myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #16: Don't duplicate count() functionality.
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/16
[](https://coveralls.io/builds/9882175)
Coverage increased (+0.2%) to 84.291% when pulling **f71a4cd326eff69b42ed4860d8359af4df1d2ecf on thomasmey:work/misc** into **12b7b4d93b945c77b801a26dab153d7f871aee49 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #16: Don't duplicate count() functionality.
Posted by thomasmey <gi...@git.apache.org>.
Github user thomasmey closed the pull request at:
https://github.com/apache/commons-compress/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #16: Don't duplicate count() functionality.
Posted by thomasmey <gi...@git.apache.org>.
Github user thomasmey commented on the issue:
https://github.com/apache/commons-compress/pull/16
Oops.
True, my mistake. Maybe we should cover this with a unit test...
Sorry for the fuss.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #16: Don't duplicate count() functionality.
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/16
Hmm, the no-arg `read` returns the byte read. So when reading an `'A'` your code would count 65 bytes rather than 1, wouldn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org