You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/09/28 15:50:25 UTC
[GitHub] [fineract] tonic889 opened a new pull request #1356: per fineract issue #1113 and community-app issue #2225, add a validat…
tonic889 opened a new pull request #1356:
URL: https://github.com/apache/fineract/pull/1356
…ion error when a user attempts a recovery repayment which is greater than the total written off for the loan
## Description
Return a validation error if the user tries to enter a recovery payment which is greater than the remaining written off total
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X ] Create/update unit or integration tests for verifying the changes made.
- [ X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1356: per fineract issue #1113 and community-app issue #2225, add a validat…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1356:
URL: https://github.com/apache/fineract/pull/1356#issuecomment-700124462
@tonic889 what is "Fineract Issue 1133"? Doesn't seem to be related to https://issues.apache.org/jira/browse/FINERACT-1133 nor Pull Request #1133... It would be great to have an issue on JIRA, would you like to create one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1356: Fineract-1113 Add validation error for recovery repayments
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1356:
URL: https://github.com/apache/fineract/pull/1356#issuecomment-700812427
I've merged it now, by using Github "Squash", so it became a single commit, and I've adapted the message. Tips for future use:
> Hi. Now I've somehow got an extra commit ([8964940](https://github.com/apache/fineract/commit/8964940108e623201ef1df0e7531301f7ee1da5c)) in here.
That's a "merge commit". If you use `git rebase develop` instead of `merge`, you avoid those _merge commits._
> I tried to roll it back via git reset --soft HEAD~1 and another git push but I'm getting an " Updates were rejected because the tip of your current branch is behind hint: its remote counterpart." error.
You need to use `git push --force [tonic889]` in that case.
> Sorry, I'm still new to git and it never works the way I expect it to.
I'm sure you'll learn! Keep sending PRs - practice is the best way to learn... :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] tonic889 commented on pull request #1356: per fineract issue #1113 and community-app issue #2225, add a validat…
Posted by GitBox <gi...@apache.org>.
tonic889 commented on pull request #1356:
URL: https://github.com/apache/fineract/pull/1356#issuecomment-700126189
@vorburger hi, it's 1113 not 1133, sorry if I made a typo somewhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1356: per fineract issue #1113 and community-app issue #2225, add a validat…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1356:
URL: https://github.com/apache/fineract/pull/1356#issuecomment-700169705
@tonic889 oh, this is a follow-up to #1306 re. FINERACT-1113.. now I get it.
Do you mind if I asked if you would be willing to `git commit --amend` this and write the commit message as per https://github.com/apache/fineract/#pull-requests? Your commit is too long (break it upinto a shorter first line, then empty line, then explanation; see history) and doesn't correctly refer to the issue; when you refer to a JIRA issue on issues.apache.org, do use FINERACT-xxx. If you use #... then it's a GitHub Pull Request link.
Thank You for contributing! We're excited to see this recent 2nd PR from you. I've noticed that [you were around in 2017 & 2018 as well](https://github.com/apache/fineract/pulls?q=is%3Apr+author%3Atonic889+is%3Aclosed). We hope to see more from you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1356: Fineract-1113 Add validation error for recovery repayments
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1356:
URL: https://github.com/apache/fineract/pull/1356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] tonic889 commented on pull request #1356: per fineract issue #1113 and community-app issue #2225, add a validat…
Posted by GitBox <gi...@apache.org>.
tonic889 commented on pull request #1356:
URL: https://github.com/apache/fineract/pull/1356#issuecomment-700390393
Hi. Now I've somehow got an extra commit (8964940) in here. I tried to roll it back via git reset --soft HEAD~1 and another git push but I'm getting an " Updates were rejected because the tip of your current branch is behind hint: its remote counterpart." error. Sorry, I'm still new to git and it never works the way I expect it to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org