You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/04/01 19:06:00 UTC
[jira] [Work logged] (BEAM-12033) Validate casts from double
literals to numeric during expression conversion.
[ https://issues.apache.org/jira/browse/BEAM-12033?focusedWorklogId=575688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575688 ]
ASF GitHub Bot logged work on BEAM-12033:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/21 19:05
Start Date: 01/Apr/21 19:05
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #14393:
URL: https://github.com/apache/beam/pull/14393#issuecomment-812111282
R: @apilloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 575688)
Time Spent: 1h 20m (was: 1h 10m)
> Validate casts from double literals to numeric during expression conversion.
> ----------------------------------------------------------------------------
>
> Key: BEAM-12033
> URL: https://issues.apache.org/jira/browse/BEAM-12033
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Fix For: 2.29.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Numeric values in ZetaSQL are subject to constraints: they must fall within certain hardcoded limits, and the scale also cannot exceed 9. Currently we have stricter constraints than these when preparing the expression in BeamZetaSqlCalcRel due to BEAM-12046. However, to force BeamCalcRel to have correct behavior, we should check the constraints earlier, during expression conversion.
> https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/javatests/com/google/zetasql/ValueTest.java#L727-L745
--
This message was sent by Atlassian Jira
(v8.3.4#803005)