You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/02/08 01:36:36 UTC
Review Request 65561: WIP: Added more type util tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65561/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-2487
https://issues.apache.org/jira/browse/MESOS-2487
Repository: mesos
Description
-------
These are meant to exercise some rules defined by the
operator== refactor, but should also pass without the
refactor applied.
Diffs
-----
src/tests/common/type_utils_tests.cpp a962b397a2340694232ab13ea9eca7fff78d35e2
Diff: https://reviews.apache.org/r/65561/diff/1/
Testing
-------
Thanks,
Joseph Wu
Re: Review Request 65561: WIP: Added more type util tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65561/#review197071
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65540', '65541', '65561']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65561
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65561/logs/mesos-tests-stdout.log):
```
[ RUN ] ResourcesOperationTest.FlattenResources
[ OK ] ResourcesOperationTest.FlattenResources (1 ms)
[----------] 12 tests from ResourcesOperationTest (27 ms total)
[----------] 6 tests from RevocableResourceTest
[ RUN ] RevocableResourceTest.Equals
[ OK ] RevocableResourceTest.Equals (1 ms)
[ RUN ] RevocableResourceTest.Addition
[ OK ] RevocableResourceTest.Addition (1 ms)
[ RUN ] RevocableResourceTest.Subtraction
[ OK ] RevocableResourceTest.Subtraction (0 ms)
[ RUN ] RevocableResourceTest.Contains
[ OK ] RevocableResourceTest.Contains (1 ms)
[ RUN ] RevocableResourceTest.Filter
[ OK ] RevocableResourceTest.Filter (1 ms)
[ RUN ] RevocableResourceTest.Find
[ OK ] RevocableResourceTest.Find (1 ms)
[----------] 6 tests from RevocableResourceTest (9 ms total)
[----------] 6 tests from ResourceFormatTest
[ RUN ] ResourceFormatTest.PreReservationRefinement
[ OK ] ResourceFormatTest.PreReservationRefinement (0 ms)
[ RUN ] ResourceFormatTest.PostReservationRefinement
[ OK ] ResourceFormatTest.PostReservationRefinement (0 ms)
[ RUN ] ResourceFormatTest.Endpoint
[ OK ] ResourceFormatTest.Endpoint (1 ms)
[ RUN ] ResourceFormatTest.DowngradeWithoutResources
[ OK ] ResourceFormatTest.DowngradeWithoutResources (1 ms)
[ RUN ] ResourceFormatTest.DowngradeWithResourcesWithoutRefinedReservations
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65561/logs/mesos-tests-stderr.log):
```
@ 00007FF706844521 google::LogMessageFatal::~LogMessageFatal
@ 00007FF7049B4C48 mesos::Resources::isEmpty
@ 00007FF7049B0568 mesos::Resources::Resource_::isEmpty
@ 00007FF7049BA97D mesos::Resources::add
@ 00007FF7049BAD06 mesos::Resources::operator+=
@ 00007FF7049B9DF6 mesos::Resources::operator+=
@ 00007FF7049B6710 mesos::Resources::Resources
@ 00007FF703EBE110 mesos::MesosFieldComparator::Compare
@ 00007FF7071E1E43 google::protobuf::util::MessageDifferencer::GetFieldComparisonResult
@ 00007FF7071E1B2A google::protobuf::util::MessageDifferencer::CompareFieldValueUsingParentFields
@ 00007FF7071E1612 google::protobuf::util::MessageDifferencer::CompareRepeatedField
@ 00007FF7071E1153 google::protobuf::util::MessageDifferencer::CompareWithFieldsInternal
@ 00007FF7071E0978 google::protobuf::util::MessageDifferencer::CompareRequestedFieldsUsingSettings
@ 00007FF7071DF995 google::protobuf::util::MessageDifferencer::Compare
@ 00007FF7071DD661 google::protobuf::util::MessageDifferencer::Compare
@ 00007FF703EB88F3 mesos::operator==
@ 00007FF7038C7594 testing::internal::CmpHelperEQ<mesos::TaskInfo,mesos::TaskInfo>
@ 00007FF7038C9EC8 testing::internal::EqHelper<0>::Compare<mesos::TaskInfo,mesos::TaskInfo>
@ 00007FF7038A2C48 mesos::internal::tests::ResourceFormatTest_DowngradeWithResourcesWithoutRefinedReservations_Test::TestBody
@ 00007FF70734FC61 testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,void>
@ 00007FF70734F86D testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
@ 00007FF70732E5C3 testing::Test::Run
@ 00007FF70732F1C6 testing::TestInfo::Run
@ 00007FF70732F976 testing::TestCase::Run
@ 00007FF707336B0B testing::internal::UnitTestImpl::RunAllTests
@ 00007FF70734FED1 testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
@ 00007FF70734FB8D testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
@ 00007FF707330075 testing::UnitTest::Run
@ 00007FF7028F9BE2 RUN_ALL_TESTS
```
- Mesos Reviewbot Windows
On Feb. 8, 2018, 1:36 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65561/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 1:36 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-2487
> https://issues.apache.org/jira/browse/MESOS-2487
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These are meant to exercise some rules defined by the
> operator== refactor, but should also pass without the
> refactor applied.
>
>
> Diffs
> -----
>
> src/tests/common/type_utils_tests.cpp a962b397a2340694232ab13ea9eca7fff78d35e2
>
>
> Diff: https://reviews.apache.org/r/65561/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joseph Wu
>
>