You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 16:26:16 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #12928: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled

westonpace commented on code in PR #12928:
URL: https://github.com/apache/arrow/pull/12928#discussion_r854332572


##########
cpp/src/arrow/util/bitmap_writer.h:
##########
@@ -78,96 +79,24 @@ class BitmapWriter {
   int64_t byte_offset_;
 };
 
-class FirstTimeBitmapWriter {
+class ARROW_EXPORT FirstTimeBitmapWriter {

Review Comment:
   Since the other classes are fully defined in the header you should not have to.  Technically it wouldn't hurt either but best to be minimal with changes probably.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org