You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mikhail Fursov (JIRA)" <ji...@apache.org> on 2007/04/06 15:10:32 UTC
[jira] Created: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
[drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
--------------------------------------------------------------------
Key: HARMONY-3587
URL: https://issues.apache.org/jira/browse/HARMONY-3587
Project: Harmony
Issue Type: New Feature
Components: DRLVM
Reporter: Mikhail Fursov
I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487478 ]
Alexey Varlamov commented on HARMONY-3587:
------------------------------------------
Mihkail, which OS(es) and workloads did you test?
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: helpers.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487484 ]
Alexey Varlamov commented on HARMONY-3587:
------------------------------------------
Yes, please 'build test -Dtest.mode=srv' on Winx64.
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: helpers.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov updated HARMONY-3587:
------------------------------------
Attachment: helpers.diff
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: helpers.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487480 ]
Mikhail Fursov commented on HARMONY-3587:
-----------------------------------------
I've tested with microtests to measure performance effect and run 2 specs: 98 and 2005 on Windows.
All of the fixes were developed on Linux a couple of weeks before so I run the same scenarios on Linux.
I didn't run 'build test' before submitting the patch because you'll do it anyway.
Do you want me to run the tests for Windows 64bit?
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: helpers.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-3587:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: helpers.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3587) [drlvm][em64t][jit] Enabling vmhelper
inlining for EM64T server mode
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov closed HARMONY-3587.
------------------------------------
Resolution: Fixed
Applied at r527065, thanks!
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: helpers.diff, helpers2.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3587) [drlvm][em64t][jit] Enabling
vmhelper inlining for EM64T server mode
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov updated HARMONY-3587:
------------------------------------
Attachment: helpers2.diff
Alexey, I tested release build before and did not found the problem that I forgot to remove some assertions in debug mode about EM64T vmhelpers support.
new fix includes all the changes needed to be commited.
I run test as you asked and have the following result:
All tests passed in debug mode except these message:
[echo] Running test : shutdown.TestFatalError
[java] Java Result: 1
[echo] PASSED : shutdown.TestFatalError
[echo] Running test : shutdown.TestInterrupt
[java] Java Result: 130
[echo] PASSED : shutdown.TestInterrupt
[echo] Running test : shutdown.TestLock
[java] Java Result: 3
[echo] *** FAILED **** : shutdown.TestLock
[echo] Running test : stress.BigStringBuffer
I rerun these tests manually and all of them printed PASSED. I think this is VM shutdown&return code problem but not vmhelpers issue.
> [drlvm][em64t][jit] Enabling vmhelper inlining for EM64T server mode
> --------------------------------------------------------------------
>
> Key: HARMONY-3587
> URL: https://issues.apache.org/jira/browse/HARMONY-3587
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: helpers.diff, helpers2.diff
>
>
> I have successfuly tested and turned ON vm helpers inlining (2 alloc && 2 monitors helpers) for EM64T platform in server mode.
> The only changes are in server.emconf file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.