You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/16 17:02:18 UTC

[GitHub] [airflow] dstandish commented on pull request #19596: MsSqlHook: implement _generate_insert_sql

dstandish commented on pull request #19596:
URL: https://github.com/apache/airflow/pull/19596#issuecomment-970474540


   @jplauri regarding your question about merge vs insert, i think merge is the right call.  That list of issues  is pretty ancient now.  Merge was implemented in 2008 and by now, I think most of the meaningful kinks have been ironed out.  I would bet that the rowcount approach would be slow since it limits you to row-by-row.
   
   But I don't think you need to tackle that in this PR.  One thing at a time.  Can do this limited case first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org