You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/31 20:27:16 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #2633: BL602: Add support for system reset modes
btashton opened a new pull request #2633:
URL: https://github.com/apache/incubator-nuttx/pull/2633
## Summary
This adds support for issuing software rests on the bl602 chip.
## Impact
Add support for issuing software resets.
## Testing
Enabled the reboot nsh builtin command and programmed the EVKB board.
```
NuttShell (NSH) NuttX-10.0.1
nsh> uname -a
NuttX 10.0.1 c647faa117-dirty Dec 31 2020 10:52:08 risc-v bl602evb
nsh> reboot
NuttShell (NSH) NuttX-10.0.1
nsh> uname -a
NuttX 10.0.1 c647faa117-dirty Dec 31 2020 10:52:08 risc-v bl602evb
nsh>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2633: BL602: Add support for system reset modes
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2633:
URL: https://github.com/apache/incubator-nuttx/pull/2633#issuecomment-753410702
@xiaoxiang781216 Updated it:
Note that using a CPU reset will cause the device to hang in most cases. Default reboot is sent to the system reboot.
```
NuttShell (NSH) NuttX-10.0.1
nsh> reboot
NuttShell (NSH) NuttX-10.0.1
nsh> reboot 0
NuttShell (NSH) NuttX-10.0.1
nsh> reboot 2
�
NuttShell (NSH) NuttX-10.0.1
nsh> reboot 1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2633: BL602: Add support for system reset modes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2633:
URL: https://github.com/apache/incubator-nuttx/pull/2633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2633: BL602: Add support for system reset modes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2633:
URL: https://github.com/apache/incubator-nuttx/pull/2633#discussion_r550747738
##########
File path: boards/risc-v/bl602/bl602evb/src/bl602_reset.c
##########
@@ -0,0 +1,59 @@
+/****************************************************************************
+ * boards/risc-v/bl602/evb/src/bl602_reset.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <nuttx/arch.h>
+#include <nuttx/board.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: board_reset
+ *
+ * Description:
+ * Reset board. Support for this function is required by board-level
+ * logic if CONFIG_BOARDCTL_RESET is selected.
+ *
+ * Input Parameters:
+ * status - Status information provided with the reset event. This
+ * meaning of this status information is board-specific. If not
+ * used by a board, the value zero may be provided in calls to
+ * board_reset().
+ *
+ * Returned Value:
+ * If this function returns, then it was not possible to power-off the
+ * board due to some constraints. The return value int this case is a
+ * board-specific reason for the failure to shutdown.
+ *
+ ****************************************************************************/
+
+int board_reset(int status)
+{
+ up_systemreset();
Review comment:
how about we use status to select the different reset(system, cpu...)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2633: BL602: Add support for system reset modes
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2633:
URL: https://github.com/apache/incubator-nuttx/pull/2633#discussion_r550818285
##########
File path: boards/risc-v/bl602/bl602evb/src/bl602_reset.c
##########
@@ -0,0 +1,59 @@
+/****************************************************************************
+ * boards/risc-v/bl602/evb/src/bl602_reset.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <nuttx/arch.h>
+#include <nuttx/board.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: board_reset
+ *
+ * Description:
+ * Reset board. Support for this function is required by board-level
+ * logic if CONFIG_BOARDCTL_RESET is selected.
+ *
+ * Input Parameters:
+ * status - Status information provided with the reset event. This
+ * meaning of this status information is board-specific. If not
+ * used by a board, the value zero may be provided in calls to
+ * board_reset().
+ *
+ * Returned Value:
+ * If this function returns, then it was not possible to power-off the
+ * board due to some constraints. The return value int this case is a
+ * board-specific reason for the failure to shutdown.
+ *
+ ****************************************************************************/
+
+int board_reset(int status)
+{
+ up_systemreset();
Review comment:
Ok. None of the other boards used this status flag so I had not used it, but I can implement that, I see that the nsh reboot command does allow for passing the argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2633: BL602: Add support for system reset modes
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2633:
URL: https://github.com/apache/incubator-nuttx/pull/2633#issuecomment-753143774
@Virus-V FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org