You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2011/03/04 18:15:47 UTC
Re: svn commit: r1077935 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java
On 4 March 2011 13:31, <sc...@apache.org> wrote:
> Author: scolebourne
> Date: Fri Mar 4 13:31:39 2011
> New Revision: 1077935
>
> URL: http://svn.apache.org/viewvc?rev=1077935&view=rev
> Log:
> Make rounding mode constants private, as they are unused in public
Or they could be enums?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1077935 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java
Posted by Stephen Colebourne <sc...@joda.org>.
As there is no need to be public, I'm not fussed that they are int. An
enum just increase the jar file size for little benefit when you have
private values.
Stephen
On 4 March 2011 17:15, sebb <se...@gmail.com> wrote:
> On 4 March 2011 13:31, <sc...@apache.org> wrote:
>> Author: scolebourne
>> Date: Fri Mar 4 13:31:39 2011
>> New Revision: 1077935
>>
>> URL: http://svn.apache.org/viewvc?rev=1077935&view=rev
>> Log:
>> Make rounding mode constants private, as they are unused in public
>
> Or they could be enums?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org