You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/20 10:10:38 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #10139: Add CREATE SHARDING BROADCAST TABLE RULES
menghaoranss opened a new pull request #10139:
URL: https://github.com/apache/shardingsphere/pull/10139
refer #10123 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10139: Add CREATE SHARDING BROADCAST TABLE RULES
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10139:
URL: https://github.com/apache/shardingsphere/pull/10139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10139: Add CREATE SHARDING BROADCAST TABLE RULES
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10139:
URL: https://github.com/apache/shardingsphere/pull/10139#discussion_r617139362
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -55,6 +55,8 @@
DUPLICATE_TABLE(1113, "C1113", "Duplicate table names %s."),
+ SHARDING_BROADCAST_EXIST(1114, "C1114", "Sharding broadcast table rules already exists in schema %s."),
Review comment:
`exists` -> `exist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10139: Add CREATE SHARDING BROADCAST TABLE RULES
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #10139:
URL: https://github.com/apache/shardingsphere/pull/10139#discussion_r617141222
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.java
##########
@@ -55,6 +55,8 @@
DUPLICATE_TABLE(1113, "C1113", "Duplicate table names %s."),
+ SHARDING_BROADCAST_EXIST(1114, "C1114", "Sharding broadcast table rules already exists in schema %s."),
Review comment:
modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org