You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2025/08/15 04:23:47 UTC
[PR] Add support for programmatically providing runtime values for configuration option values [logging-log4cxx]
swebb2066 opened a new pull request, #520:
URL: https://github.com/apache/logging-log4cxx/pull/520
See the example config4.cpp for how this works.
Note: I also removed support for the "log4j.configuration" environment variable as it is not supported by Log4j2 anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for programmatically providing runtime values for configuration option values [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #520:
URL: https://github.com/apache/logging-log4cxx/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for programmatically providing runtime values for configuration option values [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on PR #520:
URL: https://github.com/apache/logging-log4cxx/pull/520#issuecomment-3192165241
> Note: I also removed support for the "log4j.configuration" environment variable as it is not supported by Log4j2 anyway.
Do we want to remove it now, or should we wait for the next major version? This would be a breaking change.
the reason it is `log4j.configuration` is that it follows the Log4j1 variable name.
I would also recommend that the behavior added in this PR have an option to explicitly disable this new feature via an environment variable. I'm thinking back to log4shell, which was caused by abusing string replacements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for programmatically providing runtime values for configuration option values [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on code in PR #520:
URL: https://github.com/apache/logging-log4cxx/pull/520#discussion_r2279479284
##########
src/main/include/log4cxx/helpers/system.h:
##########
@@ -34,18 +34,33 @@ class LOG4CXX_EXPORT System
{
public:
+
/**
- Gets the system property indicated by the specified key.
+ Add to \c props the currently executing program file path
+ and the [std::filesystem::path](https://en.cppreference.com/w/cpp/filesystem/path.html)
+ decomposition of the currently executing program file path, using the variable names:
+ - PROGRAM_FILE_PATH
Review Comment:
it would be nice if you could add some documentation(examples) on what all of these variables look like at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org