You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/08/25 12:31:04 UTC

[GitHub] flink pull request #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerIT...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4591

    [FLINK-7514][tests] fix BackPressureStatsTrackerITCase releasing buffers twice

    ## What is the purpose of the change
    
    `BackPressureStatsTrackerITCase#testBackPressuredProducer()` is releasing its buffers twice which is fixed by this PR while making sure they are actually released.
    
    ## Brief change log
    
    - remove duplicate `buf.recycle()`
    - ensure buffers are released when expected
    
    ## Verifying this change
    
    This change is part of the `BackPressureStatsTrackerITCase` test.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7514

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4591
    
----
commit c889a8e387ebdaff7dcc1f967e4439586855a6b3
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-08-25T07:49:44Z

    [FLINK-7514][tests] fix BackPressureStatsTrackerITCase releasing buffers twice

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerITCase re...

Posted by NicoK <gi...@git.apache.org>.

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4591
  
    ok, that last rebase was missing an import - fixed now


---

[GitHub] flink issue #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerITCase re...

Posted by NicoK <gi...@git.apache.org>.

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4591
  
    @zentol unfortunately, when changing to using Netty's buffer counting, it will check any form of illegal reference count usages, and a double-free is one of them. Even without Netty, this pattern could result from an invalid use and may be guarded the same way.


---

[GitHub] flink issue #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerITCase re...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4591
  
    I'm wondering about the benefit here. The existing code guarantees that all buffers would be recycled in case of test failure; don't these changes allow a memory leak? Isn't `recycle()` safe anyway since it is a No-Op if called multiple times without `retain()`?


---

[GitHub] flink issue #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerITCase re...

Posted by NicoK <gi...@git.apache.org>.

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4591
  
    rebased to make it mergable again


---

[GitHub] flink issue #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerITCase re...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4591
  
    Thanks for your contribution @NicoK and the reviews @pnowojski and @zentol. Changes look good. If Travis passes, then I'll merge the PR.


---

[GitHub] flink pull request #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerIT...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4591


---