You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "eugen-keeper (via GitHub)" <gi...@apache.org> on 2026/04/22 02:19:31 UTC
[PR] GUACAMOLE-2120: Ensure guac_terminal_options is zero-initialized. [guacamole-server]
eugen-keeper opened a new pull request, #663:
URL: https://github.com/apache/guacamole-server/pull/663
The current use of `guac_mem_alloc` leaves the `guac_terminal_options` struct with uninitialized memory. This creates a fragile pattern where any future addition to the struct requires either manual initialization of the new field across all consumer functions, or explicit initialization within the allocation function itself.
If a developer adds a property but misses an initialization step, the field will contain indeterminate "garbage" data, leading to intermittent bugs, logic errors, or crashes that are difficult to debug. Switching to `guac_mem_zalloc` provides a fail-safe default of zero/NULL for all members, ensuring predictable behavior and preventing regressions as the API evolves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2120: Ensure guac_terminal_options is zero-initialized. [guacamole-server]
Posted by "sschiffli (via GitHub)" <gi...@apache.org>.
sschiffli merged PR #663:
URL: https://github.com/apache/guacamole-server/pull/663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2120: Ensure guac_terminal_options is zero-initialized. [guacamole-server]
Posted by "sschiffli (via GitHub)" <gi...@apache.org>.
sschiffli commented on PR #663:
URL: https://github.com/apache/guacamole-server/pull/663#issuecomment-4306111498
Is main the correct target for this? Or should it go into staging/1.6.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org