You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-commits@incubator.apache.org by rf...@apache.org on 2011/12/06 16:56:54 UTC
svn commit: r1211019 -
/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
Author: rfrovarp
Date: Tue Dec 6 16:56:53 2011
New Revision: 1211019
URL: http://svn.apache.org/viewvc?rev=1211019&view=rev
Log:
Add a comment about order of operations
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
Modified: incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
URL: http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java?rev=1211019&r1=1211018&r2=1211019&view=diff
==============================================================================
--- incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java (original)
+++ incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java Tue Dec 6 16:56:53 2011
@@ -61,6 +61,8 @@ public class SimpleTaskQueueWithHistory<
{
boolean hasChanged = false;
for (T e : c) {
+ // Must be in this order otherwise the short circuiting or
+ // will make it so that items aren't added.
hasChanged = this.add(e) || hasChanged;
}
return hasChanged;