[jira] [Commented] (PHOENIX-5551) Update maven apache parent to version 21

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962315#comment-16962315 ] 

Hadoop QA commented on PHOENIX-5551:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12984276/PHOENIX-5551.master.v1.patch
  against master branch at commit 6ce24abf310ff1d0fb8976a02be5758a6d311ab2.
  ATTACHMENT ID: 12984276

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:red}-1 javac{color}.  The applied patch generated 385 javac compiler warnings (more than the master's current 384 warnings).

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3080//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3080//console

This message is automatically generated.

> Update maven apache parent to version 21
> ----------------------------------------
>
>                 Key: PHOENIX-5551
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5551
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.1.0
>            Reporter: István Tóth
>            Assignee: István Tóth
>            Priority: Minor
>         Attachments: PHOENIX-5551.master.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Phoenix maven project sets _org.apache:apache_ as maven parent. 
> Most of the functionality of the apache parent is setting up base plugin configuration, including versions for maven plugins.
> The current pom.xml ignores most of the versions, and  sets the plugin versions manually.
> I propose updating the apache parent artifact to the latest version (21), and removing the explicit plugin version settings where the plugin versions are set by apache parent.
> This effectively updates some plugins, leaves some at the same version, but does not downgrade any of them.
> This is the effective plugin version change with this patch:
> org.apache:apache 14 -> 21
> org.apache.maven.plugins:maven-compiler-plugin 3.0 -> 3.7.0
> org.apache.maven.plugins:maven-install-plugin 2.5.2 -> 2.5.2
> org.apache.maven.plugins:maven-assembly-plugin 2.5.2 -> 3.0.0
> org.apache.maven.plugins:maven-failsafe-plugin 2.22.2 -> 2.22.2
> org.apache.maven.plugins:maven-dependency-plugin 2.1 -> 3.1.1
> org.apache.maven.plugins:maven-shade-plugin 3.1.1 -> 3.1.1
> org.apache.maven.plugins:maven-source-plugin 2.2.1 -> 3.0.1
> org.apache.maven.plugins:maven-javadoc-plugin 2.9 -> 3.0.1
> org.apache.maven.plugins:maven-surefire-plugin 2.22.2 -> 2.22.2
> org.apache.maven.plugins:maven-jar-plugin 2.4 -> 3.1.0
> org.apache.maven.plugins:maven-site-plugin 3.7.1 -> 3.7.1
> org.apache.maven.plugins:maven-gpg-plugin 1.6 -> 1.6
> org.apache.maven.plugins:maven-project-info-reports-plugin 3.0.0 -> 3.0.0
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)