You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2014/06/27 22:32:20 UTC
[2/5] git commit: Fix checkstyle errors and various warnings.
Fix checkstyle errors and various warnings.
Project: http://git-wip-us.apache.org/repos/asf/incubator-flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-flink/commit/3c5feae7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-flink/tree/3c5feae7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-flink/diff/3c5feae7
Branch: refs/heads/master
Commit: 3c5feae7da1a52cb928bccf7bee43d4f98faf2c5
Parents: 0d0803f
Author: Stephan Ewen <se...@apache.org>
Authored: Fri Jun 27 20:37:09 2014 +0200
Committer: Stephan Ewen <se...@apache.org>
Committed: Fri Jun 27 21:22:02 2014 +0200
----------------------------------------------------------------------
.../src/main/java/eu/stratosphere/api/java/operators/Keys.java | 1 +
.../api/java/typeutils/runtime/PojoPairComparator.java | 1 +
.../eu/stratosphere/api/java/operator/CoGroupOperatorTest.java | 2 --
.../java/eu/stratosphere/api/java/operator/GroupingTest.java | 2 --
.../java/eu/stratosphere/api/java/operator/JoinOperatorTest.java | 3 ---
.../api/java/type/extractor/PojoTypeInformationTest.java | 4 +---
.../api/java/typeutils/runtime/PojoSerializerTest.java | 2 --
.../nephele/instance/HardwareDescriptionFactory.java | 2 --
.../eu/stratosphere/test/javaApiOperators/DistinctITCase.java | 1 -
9 files changed, 3 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/Keys.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/Keys.java b/stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/Keys.java
index 8e879d7..3477e00 100644
--- a/stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/Keys.java
+++ b/stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/Keys.java
@@ -187,6 +187,7 @@ public abstract class Keys<T> {
private final TypeInformation<?>[] types;
+ @SuppressWarnings("unused")
private PojoTypeInfo<?> type;
public ExpressionKeys(String[] expressions, TypeInformation<T> type) {
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/main/java/eu/stratosphere/api/java/typeutils/runtime/PojoPairComparator.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/main/java/eu/stratosphere/api/java/typeutils/runtime/PojoPairComparator.java b/stratosphere-java/src/main/java/eu/stratosphere/api/java/typeutils/runtime/PojoPairComparator.java
index e8b4240..c862f13 100644
--- a/stratosphere-java/src/main/java/eu/stratosphere/api/java/typeutils/runtime/PojoPairComparator.java
+++ b/stratosphere-java/src/main/java/eu/stratosphere/api/java/typeutils/runtime/PojoPairComparator.java
@@ -28,6 +28,7 @@ public class PojoPairComparator<T1, T2> extends TypePairComparator<T1, T2> imple
private static final long serialVersionUID = 1L;
+ @SuppressWarnings("unused")
private final int[] keyPositions1, keyPositions2;
private transient Field[] keyFields1, keyFields2;
private final TypeComparator<Object>[] comparators1;
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/CoGroupOperatorTest.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/CoGroupOperatorTest.java b/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/CoGroupOperatorTest.java
index b17e4b9..e4cc949 100644
--- a/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/CoGroupOperatorTest.java
+++ b/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/CoGroupOperatorTest.java
@@ -18,8 +18,6 @@ import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;
-import eu.stratosphere.api.java.typeutils.TypeExtractor;
-import eu.stratosphere.types.TypeInformation;
import junit.framework.Assert;
import org.junit.BeforeClass;
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/GroupingTest.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/GroupingTest.java b/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/GroupingTest.java
index 6e7fb65..ad51361 100644
--- a/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/GroupingTest.java
+++ b/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/GroupingTest.java
@@ -18,8 +18,6 @@ import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;
-import eu.stratosphere.api.java.typeutils.TypeExtractor;
-import eu.stratosphere.types.TypeInformation;
import junit.framework.Assert;
import org.junit.Test;
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/JoinOperatorTest.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/JoinOperatorTest.java b/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/JoinOperatorTest.java
index f5d5dee..32747c1 100644
--- a/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/JoinOperatorTest.java
+++ b/stratosphere-java/src/test/java/eu/stratosphere/api/java/operator/JoinOperatorTest.java
@@ -14,13 +14,10 @@
**********************************************************************************************************************/
package eu.stratosphere.api.java.operator;
-import java.beans.Expression;
import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;
-import eu.stratosphere.api.java.typeutils.TypeExtractor;
-import eu.stratosphere.types.TypeInformation;
import junit.framework.Assert;
import org.junit.BeforeClass;
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/test/java/eu/stratosphere/api/java/type/extractor/PojoTypeInformationTest.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/test/java/eu/stratosphere/api/java/type/extractor/PojoTypeInformationTest.java b/stratosphere-java/src/test/java/eu/stratosphere/api/java/type/extractor/PojoTypeInformationTest.java
index 065ae0c..772050a 100644
--- a/stratosphere-java/src/test/java/eu/stratosphere/api/java/type/extractor/PojoTypeInformationTest.java
+++ b/stratosphere-java/src/test/java/eu/stratosphere/api/java/type/extractor/PojoTypeInformationTest.java
@@ -13,17 +13,15 @@
package eu.stratosphere.api.java.type.extractor;
-import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import org.junit.Test;
import eu.stratosphere.api.java.typeutils.PojoTypeInfo;
import eu.stratosphere.api.java.typeutils.TypeExtractor;
-import eu.stratosphere.types.Record;
-import eu.stratosphere.types.StringValue;
import eu.stratosphere.types.TypeInformation;
+@SuppressWarnings("unused")
public class PojoTypeInformationTest {
static class SimplePojo {
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-java/src/test/java/eu/stratosphere/api/java/typeutils/runtime/PojoSerializerTest.java
----------------------------------------------------------------------
diff --git a/stratosphere-java/src/test/java/eu/stratosphere/api/java/typeutils/runtime/PojoSerializerTest.java b/stratosphere-java/src/test/java/eu/stratosphere/api/java/typeutils/runtime/PojoSerializerTest.java
index 8adb83b..c66e314 100644
--- a/stratosphere-java/src/test/java/eu/stratosphere/api/java/typeutils/runtime/PojoSerializerTest.java
+++ b/stratosphere-java/src/test/java/eu/stratosphere/api/java/typeutils/runtime/PojoSerializerTest.java
@@ -17,8 +17,6 @@ package eu.stratosphere.api.java.typeutils.runtime;
import java.util.Random;
import com.google.common.base.Objects;
-import com.google.common.hash.HashFunction;
-import com.google.common.hash.Hashing;
import eu.stratosphere.api.common.typeutils.SerializerTestBase;
import eu.stratosphere.api.common.typeutils.TypeSerializer;
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-runtime/src/main/java/eu/stratosphere/nephele/instance/HardwareDescriptionFactory.java
----------------------------------------------------------------------
diff --git a/stratosphere-runtime/src/main/java/eu/stratosphere/nephele/instance/HardwareDescriptionFactory.java b/stratosphere-runtime/src/main/java/eu/stratosphere/nephele/instance/HardwareDescriptionFactory.java
index 955c0c9..b633032 100644
--- a/stratosphere-runtime/src/main/java/eu/stratosphere/nephele/instance/HardwareDescriptionFactory.java
+++ b/stratosphere-runtime/src/main/java/eu/stratosphere/nephele/instance/HardwareDescriptionFactory.java
@@ -23,8 +23,6 @@ import java.util.regex.Pattern;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import eu.stratosphere.configuration.ConfigConstants;
-import eu.stratosphere.configuration.GlobalConfiguration;
import eu.stratosphere.util.OperatingSystem;
/**
http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/3c5feae7/stratosphere-tests/src/test/java/eu/stratosphere/test/javaApiOperators/DistinctITCase.java
----------------------------------------------------------------------
diff --git a/stratosphere-tests/src/test/java/eu/stratosphere/test/javaApiOperators/DistinctITCase.java b/stratosphere-tests/src/test/java/eu/stratosphere/test/javaApiOperators/DistinctITCase.java
index 11fcf97..28caed8 100644
--- a/stratosphere-tests/src/test/java/eu/stratosphere/test/javaApiOperators/DistinctITCase.java
+++ b/stratosphere-tests/src/test/java/eu/stratosphere/test/javaApiOperators/DistinctITCase.java
@@ -14,7 +14,6 @@
**********************************************************************************************************************/
package eu.stratosphere.test.javaApiOperators;
-import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.Collection;
import java.util.LinkedList;