You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/08/13 09:58:26 UTC

[dubbo] branch 3.0 updated: Change Service Info revision cal structure (#8478)

This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new cf8223e  Change Service Info revision cal structure (#8478)
cf8223e is described below

commit cf8223ee69f59d9391fe41ee4c293b812cd823b2
Author: Albumen Kevin <jh...@gmail.com>
AuthorDate: Fri Aug 13 17:58:14 2021 +0800

    Change Service Info revision cal structure (#8478)
    
    * Change Service Info revision cal structure
    
    * remove duplicated params
---
 .../org/apache/dubbo/metadata/MetadataInfo.java    | 38 +++++++---------------
 1 file changed, 12 insertions(+), 26 deletions(-)

diff --git a/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java b/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java
index 6849b87..c523671 100644
--- a/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java
+++ b/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java
@@ -17,7 +17,6 @@
 package org.apache.dubbo.metadata;
 
 import org.apache.dubbo.common.URL;
-import org.apache.dubbo.common.compiler.support.ClassUtils;
 import org.apache.dubbo.common.extension.ExtensionLoader;
 import org.apache.dubbo.common.url.component.URLParam;
 import org.apache.dubbo.common.utils.ArrayUtils;
@@ -25,15 +24,12 @@ import org.apache.dubbo.common.utils.CollectionUtils;
 import org.apache.dubbo.common.utils.StringUtils;
 
 import java.io.Serializable;
-import java.lang.reflect.Method;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
-import java.util.SortedSet;
 import java.util.TreeMap;
-import java.util.TreeSet;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.atomic.AtomicBoolean;
 
@@ -191,10 +187,10 @@ public class MetadataInfo implements Serializable {
     @Override
     public String toString() {
         return "metadata{" +
-                "app='" + app + "'," +
-                "revision='" + revision + "'," +
-                "services=" + services +
-                "}";
+            "app='" + app + "'," +
+            "revision='" + revision + "'," +
+            "services=" + services +
+            "}";
     }
 
     public static class ServiceInfo implements Serializable {
@@ -409,17 +405,7 @@ public class MetadataInfo implements Serializable {
         }
 
         public String toDescString() {
-            return this.getMatchKey() + getMethodSignaturesString() + new TreeMap<>(getParams());
-        }
-
-        private String getMethodSignaturesString() {
-            SortedSet<String> methodStrings = new TreeSet();
-
-            Method[] methods = ClassUtils.forName(name).getMethods();
-            for (Method method : methods) {
-                methodStrings.add(method.toString());
-            }
-            return methodStrings.toString();
+            return this.getMatchKey() + path + new TreeMap<>(getParams());
         }
 
         public void addParameter(String key, String value) {
@@ -490,13 +476,13 @@ public class MetadataInfo implements Serializable {
         @Override
         public String toString() {
             return "service{" +
-                    "name='" + name + "'," +
-                    "group='" + group + "'," +
-                    "version='" + version + "'," +
-                    "protocol='" + protocol + "'," +
-                    "params=" + params + "," +
-                    "consumerParams=" + consumerParams +
-                    "}";
+                "name='" + name + "'," +
+                "group='" + group + "'," +
+                "version='" + version + "'," +
+                "protocol='" + protocol + "'," +
+                "params=" + params + "," +
+                "consumerParams=" + consumerParams +
+                "}";
         }
     }
 }