You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gary Helmling (Created) (JIRA)" <ji...@apache.org> on 2011/10/06 05:34:29 UTC
[jira] [Created] (HBASE-4545) TestHLog doesn't clean up after
itself
TestHLog doesn't clean up after itself
--------------------------------------
Key: HBASE-4545
URL: https://issues.apache.org/jira/browse/HBASE-4545
Project: HBase
Issue Type: Bug
Components: test
Reporter: Gary Helmling
TestHLog has been hanging during shutdown of the mini cluster after all tests are run. Further investigation shows that there are many places where the TestHLog tests are not cleaning up after themselves.
Necessary changes are:
* since all tests use HLog directly, a MiniHBaseCluster is not needed. The test should only launch a MiniDFSCluster
* several tests do not close the created HLog at completion
* the test class should shutdown the mini cluster in an @AfterClass method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4545) TestHLog doesn't clean up after
itself
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121724#comment-13121724 ]
stack commented on HBASE-4545:
------------------------------
+1
Good on G.
> TestHLog doesn't clean up after itself
> --------------------------------------
>
> Key: HBASE-4545
> URL: https://issues.apache.org/jira/browse/HBASE-4545
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Gary Helmling
> Attachments: HBASE-4545.patch
>
>
> TestHLog has been hanging during shutdown of the mini cluster after all tests are run. Further investigation shows that there are many places where the TestHLog tests are not cleaning up after themselves.
> Necessary changes are:
> * since all tests use HLog directly, a MiniHBaseCluster is not needed. The test should only launch a MiniDFSCluster
> * several tests do not close the created HLog at completion
> * the test class should shutdown the mini cluster in an @AfterClass method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4545) TestHLog doesn't clean up after
itself
Posted by "Gary Helmling (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4545:
---------------------------------
Attachment: HBASE-4545.patch
The attached patch changes TestHLog to only use a MiniDFSCluster and fixes the unclosed HLog instances.
TestHLog now executes in about half the time of previously. And it passes reliably for me in a batch of 10 test runs.
> TestHLog doesn't clean up after itself
> --------------------------------------
>
> Key: HBASE-4545
> URL: https://issues.apache.org/jira/browse/HBASE-4545
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Gary Helmling
> Attachments: HBASE-4545.patch
>
>
> TestHLog has been hanging during shutdown of the mini cluster after all tests are run. Further investigation shows that there are many places where the TestHLog tests are not cleaning up after themselves.
> Necessary changes are:
> * since all tests use HLog directly, a MiniHBaseCluster is not needed. The test should only launch a MiniDFSCluster
> * several tests do not close the created HLog at completion
> * the test class should shutdown the mini cluster in an @AfterClass method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4545) TestHLog doesn't clean up after
itself
Posted by "Gary Helmling (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling resolved HBASE-4545.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Assignee: Gary Helmling
Hadoop Flags: Reviewed
Committed to trunk.
> TestHLog doesn't clean up after itself
> --------------------------------------
>
> Key: HBASE-4545
> URL: https://issues.apache.org/jira/browse/HBASE-4545
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.94.0
>
> Attachments: HBASE-4545.patch
>
>
> TestHLog has been hanging during shutdown of the mini cluster after all tests are run. Further investigation shows that there are many places where the TestHLog tests are not cleaning up after themselves.
> Necessary changes are:
> * since all tests use HLog directly, a MiniHBaseCluster is not needed. The test should only launch a MiniDFSCluster
> * several tests do not close the created HLog at completion
> * the test class should shutdown the mini cluster in an @AfterClass method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4545) TestHLog doesn't clean up after
itself
Posted by "Gary Helmling (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4545:
---------------------------------
Issue Type: Test (was: Bug)
> TestHLog doesn't clean up after itself
> --------------------------------------
>
> Key: HBASE-4545
> URL: https://issues.apache.org/jira/browse/HBASE-4545
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Gary Helmling
> Attachments: HBASE-4545.patch
>
>
> TestHLog has been hanging during shutdown of the mini cluster after all tests are run. Further investigation shows that there are many places where the TestHLog tests are not cleaning up after themselves.
> Necessary changes are:
> * since all tests use HLog directly, a MiniHBaseCluster is not needed. The test should only launch a MiniDFSCluster
> * several tests do not close the created HLog at completion
> * the test class should shutdown the mini cluster in an @AfterClass method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira