You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/05/03 00:24:13 UTC
[Impala-ASF-CR] IMPALA-11823: Add more items to Impala web UI queries page
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19417 )
Change subject: IMPALA-11823: Add more items to Impala web UI queries page
......................................................................
Patch Set 11:
(3 comments)
> Patch Set 11:
>
> Hi, Riza, that looks really good, and I've also looked into it a little, but I'm not very good at front-end development. Maybe we can create a new Jira to track this requirement and let other professionals complete it.
In that case, can we consider saving some space by merging two columns into one? Currently, the queries table still too wide to the right in my 1792x1120 resolution screen. More detailed comments in queries.tmpl.
Also, in www/common-header.tmpl, we currently have this:
<div class='container-fluid' style='width:80%'>
I think we should raise the width there to 90% to use some empty space in left and right margin.
http://gerrit.cloudera.org:8080/#/c/19417/11/www/queries.tmpl
File www/queries.tmpl:
http://gerrit.cloudera.org:8080/#/c/19417/11/www/queries.tmpl@162
PS11, Line 162: <td>{{duration}}</td>
: <td>{{queued_duration}}</td>
nit: Merge into one column and break an entry to two lines to save space?
Duration / Queued Duration
http://gerrit.cloudera.org:8080/#/c/19417/11/www/queries.tmpl@164
PS11, Line 164: <td>{{mem_usage}}</td>
: <td>{{mem_est}}</td>
nit: Merge into one column and break an entry to two lines to save space?
Mem Usage / Mem Estimate
http://gerrit.cloudera.org:8080/#/c/19417/11/www/queries.tmpl@167
PS11, Line 167: <td>{{bytes_read}}</td>
: <td>{{bytes_sent}}</td>
nit: Merge into one column and break an entry to two lines to save space?
Bytes Read / Bytes Sent
--
To view, visit http://gerrit.cloudera.org:8080/19417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19c75461a6405025fa433ae84d2c94d013fcaacb
Gerrit-Change-Number: 19417
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <18...@163.com>
Gerrit-Reviewer: Anonymous Coward <18...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 03 May 2023 00:24:13 +0000
Gerrit-HasComments: Yes