You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/01 15:15:17 UTC

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #607: GEODE-2484: Replaces ACE with boost::filesystem in stats.

pivotal-jbarrett commented on a change in pull request #607:
URL: https://github.com/apache/geode-native/pull/607#discussion_r433295688



##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -25,8 +25,7 @@
 #include "internal/DataSerializablePrimitive.hpp"
 #include "internal/geode_globals.hpp"
 
-/** @file
- */
+#undef max

Review comment:
       C preprocessor rules suck. Something included above results in leaking a macro from a system header defined as `max`. This then collides with `std::max()` resulting gibberish that won't compile. I think I may have already corrected the issue by cleaning up headers. I will pull this and see what happens now. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org