You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "jinhongyii (via GitHub)" <gi...@apache.org> on 2023/11/09 00:22:38 UTC
[PR] [Unity] Add LoadWholeParamOnWorker0 function in shard loader [tvm]
jinhongyii opened a new pull request, #16093:
URL: https://github.com/apache/tvm/pull/16093
In DistIR compilation flow, shard loading is implemented in a Relax func, like
```
a = LoadWholeParamOnWorker0(loader, index=0)
b = broadcast(a)
c = LoadWholeParamOnWorker0(loader, index=1)
d = scatter_from_worker0(c)
```
LoadWholeParamOnWorker0 loads the unsharded param on worker0, and for other workers returns an empty array.
This PR implements LoadWholeParamOnWorker0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity] Add LoadParamOnWorker0 function in shard loader [tvm]
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #16093:
URL: https://github.com/apache/tvm/pull/16093#issuecomment-1803107607
Sounds good! Let’s do that then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity] Add LoadWholeParamOnWorker0 function in shard loader [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #16093:
URL: https://github.com/apache/tvm/pull/16093#issuecomment-1803071597
How about LoadParamOnWorker0. And for future sharded version we can say LoadShardedParams
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity] Add LoadWholeParamOnWorker0 function in shard loader [tvm]
Posted by "jinhongyii (via GitHub)" <gi...@apache.org>.
jinhongyii commented on PR #16093:
URL: https://github.com/apache/tvm/pull/16093#issuecomment-1802969793
cc: @junrushao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity] Add LoadWholeParamOnWorker0 function in shard loader [tvm]
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #16093:
URL: https://github.com/apache/tvm/pull/16093#issuecomment-1803039112
The implementation looks good, but not sure what the best name tbh. @tqchen maybe you could suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity] Add LoadWholeParamOnWorker0 function in shard loader [tvm]
Posted by "jinhongyii (via GitHub)" <gi...@apache.org>.
jinhongyii commented on PR #16093:
URL: https://github.com/apache/tvm/pull/16093#issuecomment-1803090866
sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Unity] Add LoadParamOnWorker0 function in shard loader [tvm]
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #16093:
URL: https://github.com/apache/tvm/pull/16093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org