You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:40:38 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #9920: style(mypy): Enforcing typing for views.database

john-bodley opened a new pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920


   ### SUMMARY
   
   Adding `mypy` type enforcement for the `superset.views.database` module. Note because the `superset.views` module is quite large I opted to break the type enforcement into smaller more digestible chunks.
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5ce1076f3cb51d3f0e6d6a3344b078db0fee452d&el=desc) will **decrease** coverage by `0.19%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.31%   71.12%   -0.20%     
   ==========================================
     Files         585      585              
     Lines       30874    30876       +2     
     Branches     3236     3236              
   ==========================================
   - Hits        22019    21961      -58     
   - Misses       8746     8800      +54     
   - Partials      109      115       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.15% <ø> (-0.73%)` | :arrow_down: |
   | #javascript | `59.41% <ø> (ø)` | |
   | #python | `71.52% <97.50%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [5ce1076...8014f3a](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.24%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.23%   70.98%   -0.25%     
   ==========================================
     Files         585      585              
     Lines       30870    30746     -124     
     Branches     3239     3236       -3     
   ==========================================
   - Hits        21990    21825     -165     
   - Misses       8771     8806      +35     
   - Partials      109      115       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.09% <ø> (-0.75%)` | :arrow_down: |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.29% <97.50%> (-0.12%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | ... and [37 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   + Coverage   71.23%   71.28%   +0.05%     
   ==========================================
     Files         585      585              
     Lines       30870    30872       +2     
     Branches     3239     3236       -3     
   ==========================================
   + Hits        21990    22008      +18     
   + Misses       8771     8755      -16     
     Partials      109      109              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.94% <ø> (+0.11%)` | :arrow_up: |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.45% <97.50%> (+0.04%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `86.29% <0.00%> (-0.22%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   + Coverage   71.23%   71.31%   +0.07%     
   ==========================================
     Files         585      585              
     Lines       30870    30872       +2     
     Branches     3239     3236       -3     
   ==========================================
   + Hits        21990    22016      +26     
   + Misses       8771     8747      -24     
     Partials      109      109              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.86% <ø> (+0.03%)` | :arrow_up: |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.51% <97.29%> (+0.10%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `86.29% <0.00%> (-0.22%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.07% <0.00%> (+0.11%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   + Coverage   71.23%   71.32%   +0.09%     
   ==========================================
     Files         585      585              
     Lines       30870    30872       +2     
     Branches     3239     3236       -3     
   ==========================================
   + Hits        21990    22020      +30     
   + Misses       8771     8743      -28     
     Partials      109      109              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.94% <ø> (+0.11%)` | :arrow_up: |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.51% <97.50%> (+0.10%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `86.29% <0.00%> (-0.22%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.07% <0.00%> (+0.11%)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.58% <0.00%> (+0.52%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   + Coverage   71.23%   71.27%   +0.04%     
   ==========================================
     Files         585      585              
     Lines       30870    30872       +2     
     Branches     3239     3236       -3     
   ==========================================
   + Hits        21990    22004      +14     
   + Misses       8771     8759      -12     
     Partials      109      109              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.86% <ø> (+0.03%)` | :arrow_up: |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.45% <97.29%> (+0.04%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

john-bodley commented on a change in pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#discussion_r431563631



##########
File path: superset/views/database/api.py
##########
@@ -145,14 +146,14 @@ class DatabaseRestApi(DatabaseMixin, BaseSupersetModelRestApi):
 
     openapi_spec_tag = "Database"
 
-    @expose(
-        "/<int:pk>/table/<string:table_name>/<string:schema_name>/", methods=["GET"]
-    )
+    @expose("/<int:pk>/table/<table_name>/<schema_name>/", methods=["GET"])

Review comment:
       Note per [here](https://flask.palletsprojects.com/en/1.1.x/quickstart/#variable-rules) `string` is the default converter type and thus doesn't need to be explicitly defined. This is consistent with other views.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `11.81%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9920       +/-   ##
   ===========================================
   - Coverage   71.23%   59.41%   -11.82%     
   ===========================================
     Files         585      401      -184     
     Lines       30870    12740    -18130     
     Branches     3239     3239               
   ===========================================
   - Hits        21990     7570    -14420     
   + Misses       8771     4991     -3780     
   - Partials      109      179       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [315 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...28b8e5f](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

john-bodley commented on a change in pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#discussion_r430768557



##########
File path: superset/views/database/filters.py
##########
@@ -14,24 +14,26 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+from typing import Any, Optional, Set
+
 from sqlalchemy import or_
+from sqlalchemy.orm import Query
 
 from superset import security_manager
 from superset.views.base import BaseFilter
 
 
 class DatabaseFilter(BaseFilter):
     # TODO(bogdan): consider caching.
-    def schema_access_databases(self):  # noqa pylint: disable=no-self-use
-        found_databases = set()
-        for vm in security_manager.user_view_menu_names("schema_access"):
-            database_name, _ = security_manager.unpack_schema_perm(vm)
-            found_databases.add(database_name)
-        return found_databases
+    def schema_access_databases(self) -> Set[str]:  # noqa pylint: disable=no-self-use
+        return {
+            security_manager.unpack_schema_perm(vm)[0]
+            for vm in security_manager.user_view_menu_names("schema_access")
+        }
 
-    def apply(
-        self, query, func
-    ):  # noqa pylint: disable=unused-argument,arguments-differ
+    def apply(  # noqa pylint: disable=unused-argument
+        self, query: Query, value: Optional[Any]

Review comment:
       I renamed `func` to `value` for consistency with the base class.

##########
File path: superset/views/database/mixins.py
##########
@@ -214,23 +215,23 @@ def _pre_add_update(self, database):
                 "schema_access", security_manager.get_schema_perm(database, schema)
             )
 
-    def pre_add(self, database):
+    def pre_add(self, database: Database) -> None:
         self._pre_add_update(database)
 
-    def pre_update(self, database):
+    def pre_update(self, database: Database) -> None:
         self._pre_add_update(database)
 
-    def pre_delete(self, obj):  # pylint: disable=no-self-use
-        if obj.tables:
+    def pre_delete(self, database: Database) -> None:  # pylint: disable=no-self-use

Review comment:
       I renamed `obj` to `database` for consistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `4.86%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.23%   66.37%   -4.87%     
   ==========================================
     Files         585      585              
     Lines       30870    30746     -124     
     Branches     3239     3236       -3     
   ==========================================
   - Hits        21990    20407    -1583     
   - Misses       8771    10160    +1389     
   - Partials      109      179      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.29% <97.29%> (-0.12%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5ce1076f3cb51d3f0e6d6a3344b078db0fee452d&el=desc) will **decrease** coverage by `4.79%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.31%   66.52%   -4.80%     
   ==========================================
     Files         585      585              
     Lines       30874    30876       +2     
     Branches     3236     3236              
   ==========================================
   - Hits        22019    20541    -1478     
   - Misses       8746    10156    +1410     
   - Partials      109      179      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.41% <ø> (ø)` | |
   | #python | `71.52% <97.50%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [144 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [5ce1076...8014f3a](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley merged pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

john-bodley merged pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.23%   71.10%   -0.13%     
   ==========================================
     Files         585      184     -401     
     Lines       30870    18008   -12862     
     Branches     3239        0    -3239     
   ==========================================
   - Hits        21990    12805    -9185     
   + Misses       8771     5203    -3568     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.10% <97.50%> (-0.31%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <87.50%> (-20.71%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <100.00%> (-3.27%)` | :arrow_down: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <100.00%> (-4.39%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <100.00%> (-2.30%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | ... and [430 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.23%   66.26%   -4.98%     
   ==========================================
     Files         585      585              
     Lines       30870    30746     -124     
     Branches     3239     3236       -3     
   ==========================================
   - Hits        21990    20373    -1617     
   - Misses       8771    10194    +1423     
   - Partials      109      179      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.10% <97.29%> (-0.31%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <87.50%> (-20.71%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <100.00%> (-3.27%)` | :arrow_down: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <100.00%> (-4.39%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <100.00%> (-2.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5ce1076f3cb51d3f0e6d6a3344b078db0fee452d&el=desc) will **decrease** coverage by `4.83%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.31%   66.48%   -4.84%     
   ==========================================
     Files         585      585              
     Lines       30874    30876       +2     
     Branches     3236     3236              
   ==========================================
   - Hits        22019    20529    -1490     
   - Misses       8746    10168    +1422     
   - Partials      109      179      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.41% <ø> (ø)` | |
   | #python | `71.45% <97.50%> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [147 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [5ce1076...8014f3a](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.23%   71.10%   -0.13%     
   ==========================================
     Files         585      184     -401     
     Lines       30870    18008   -12862     
     Branches     3239        0    -3239     
   ==========================================
   - Hits        21990    12805    -9185     
   + Misses       8771     5203    -3568     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.10% <97.29%> (-0.31%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <87.50%> (-20.71%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <100.00%> (-3.27%)` | :arrow_down: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <100.00%> (-4.39%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <100.00%> (-2.30%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | ... and [430 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5ce1076f3cb51d3f0e6d6a3344b078db0fee452d&el=desc) will **decrease** coverage by `0.19%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.31%   71.12%   -0.20%     
   ==========================================
     Files         585      184     -401     
     Lines       30874    18016   -12858     
     Branches     3236        0    -3236     
   ==========================================
   - Hits        22019    12813    -9206     
   + Misses       8746     5203    -3543     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.12% <97.50%> (-0.41%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <87.50%> (-20.71%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <100.00%> (-3.27%)` | :arrow_down: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <100.00%> (-4.39%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <100.00%> (-2.30%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | ... and [429 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [5ce1076...8014f3a](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2c97e72959f7c79ab5ec686010e2ef7bfc118457&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9920      +/-   ##
   ==========================================
   - Coverage   71.23%   66.26%   -4.98%     
   ==========================================
     Files         585      585              
     Lines       30870    30746     -124     
     Branches     3239     3236       -3     
   ==========================================
   - Hits        21990    20373    -1617     
   - Misses       8771    10194    +1423     
   - Partials      109      179      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.41% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `71.10% <97.50%> (-0.31%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <87.50%> (-20.71%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <100.00%> (-3.27%)` | :arrow_down: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <100.00%> (-4.39%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <100.00%> (-2.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [2c97e72...b6b2ed3](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=h1) Report
   > Merging [#9920](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5ce1076f3cb51d3f0e6d6a3344b078db0fee452d&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `97.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9920/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9920   +/-   ##
   =======================================
     Coverage   71.31%   71.32%           
   =======================================
     Files         585      585           
     Lines       30874    30876    +2     
     Branches     3236     3236           
   =======================================
   + Hits        22019    22023    +4     
   + Misses       8746     8744    -2     
     Partials      109      109           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.93% <ø> (+0.06%)` | :arrow_up: |
   | #javascript | `59.41% <ø> (ø)` | |
   | #python | `71.52% <97.50%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <87.50%> (+0.34%)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `87.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (-0.61%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `84.21% <100.00%> (+0.87%)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.74% <100.00%> (+0.26%)` | :arrow_up: |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=footer). Last update [5ce1076...8014f3a](https://codecov.io/gh/apache/incubator-superset/pull/9920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9920: style(mypy): Enforcing typing for views.database

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9920:
URL: https://github.com/apache/incubator-superset/pull/9920#issuecomment-634341518






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org