[GitHub] [maven] michael-o commented on pull request #949: [MNG-7664] consolidate Velocity templates used to generate code from models

[GitBox <gi...@apache.org>]

michael-o commented on PR #949:
URL: https://github.com/apache/maven/pull/949#issuecomment-1384998905

   > > Wouldn't be shared resources module better than `${basedir}/..` magic?
   > 
   > What would be the benefit of creating an additional module and publishing the artifact if it's purely internal ? Also, I think the fact that velocity templates are used means that the templates need to be on the filesystem, which means extracting them before running modello. That sounds a bit complicated imho...
   
   First of all, the deployment can be skipped. I remember that in this exact situation we recommend users to share a module in reactor instead of dealing with path traversal. Of course, it is a bit more work. The result is the same. I will leave the decision to @hboutemy .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org