[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10556: Suppress exception stacktrace when ThreadAccountantFactory is null

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10556:
URL: https://github.com/apache/pinot/pull/10556#discussion_r1159022367


##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##########
@@ -272,8 +272,12 @@ public static void initializeThreadAccountant(PinotConfiguration config) {
           LOGGER.warn("ThreadAccountant {} register unsuccessful, as it is already registered.", factoryName);
         }
       } catch (Exception exception) {
-        LOGGER.warn("Using default implementation of thread accountant, "
-            + "due to invalid thread accountant factory {} provided, exception:", factoryName, exception);
+        if (factoryName != null) {

Review Comment:
   Should we do the null check only only construct the `ThreadAccountantFactory` when `factoryName != null`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org