You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/08 05:41:00 UTC

[jira] [Commented] (YARN-11247) Remove unused classes introduced by YARN-9615

    [ https://issues.apache.org/jira/browse/YARN-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614364#comment-17614364 ] 

ASF GitHub Bot commented on YARN-11247:
---------------------------------------

slfan1989 commented on PR #4720:
URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1272234153

   @dineshchitlangia Can you help review this pr? Thank you very much! 
   `DisableEventTypeMetrics` doesn't have any references and can be removed, remove this class and all unit tests pass.




> Remove unused classes introduced by YARN-9615
> ---------------------------------------------
>
>                 Key: YARN-11247
>                 URL: https://issues.apache.org/jira/browse/YARN-11247
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 3.4.0
>            Reporter: fanshilun
>            Assignee: fanshilun
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: DisableEventTypeMetrics-Not used.png
>
>
> YARN-9615 adds Metric to RM's dispatcher, but the patch introduces a class without any usage
> org.apache.hadoop.yarn.metrics#DisableEventTypeMetrics
> 1. Without any code references
> 2. Without any test code references
> 3. Delete this class, the local can be compiled successfully
> I think this class can be removed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org