You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/23 09:21:46 UTC
[GitHub] [solr] cpoerschke opened a new pull request, #1188: SOLR-16442: git mechanics for 'gradlew updateLicenses' in lucene-upgrade.md
cpoerschke opened a new pull request, #1188:
URL: https://github.com/apache/solr/pull/1188
https://issues.apache.org/jira/browse/SOLR-16442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #1188: SOLR-16442: git mechanics for 'gradlew updateLicenses' in lucene-upgrade.md
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #1188:
URL: https://github.com/apache/solr/pull/1188#discussion_r1038767300
##########
dev-docs/lucene-upgrade.md:
##########
@@ -43,7 +43,11 @@ gradlew --write-locks
### `solr/licenses` update
```
+git rm solr/licenses/lucene-*-9.3.0.jar.sha1
Review Comment:
ah, `git add solr/licenses` vs. `git add solr/licenses/lucene-*-9.4.0.jar.sha1` makes a difference, nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1188: SOLR-16442: git mechanics for 'gradlew updateLicenses' in lucene-upgrade.md
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1188:
URL: https://github.com/apache/solr/pull/1188#discussion_r1037112198
##########
dev-docs/lucene-upgrade.md:
##########
@@ -43,7 +43,11 @@ gradlew --write-locks
### `solr/licenses` update
```
+git rm solr/licenses/lucene-*-9.3.0.jar.sha1
Review Comment:
this step shouldn't be necessary.
If you `git add solr/licenses` it should notice the files "moved"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1188: SOLR-16442: git mechanics for 'gradlew updateLicenses' in lucene-upgrade.md
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1188:
URL: https://github.com/apache/solr/pull/1188#discussion_r1037112198
##########
dev-docs/lucene-upgrade.md:
##########
@@ -43,7 +43,11 @@ gradlew --write-locks
### `solr/licenses` update
```
+git rm solr/licenses/lucene-*-9.3.0.jar.sha1
Review Comment:
this step shouldn't be necessary.
If you `git add solr/licenses` after `./gradlew updateLicenses` - git should notice the files "moved"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #1188: SOLR-16442: git mechanics for 'gradlew updateLicenses' in lucene-upgrade.md
Posted by GitBox <gi...@apache.org>.
cpoerschke merged PR #1188:
URL: https://github.com/apache/solr/pull/1188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org