You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Rohit Deshpande (Jira)" <ji...@apache.org> on 2021/04/07 06:02:00 UTC

[jira] [Commented] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

    [ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315988#comment-17315988 ] 

Rohit Deshpande commented on KAFKA-12265:
-----------------------------------------

[~jagsancio] sorry i started the work but got preoccupied with some other commitments. I will be able to start work this weekend but please assign it to Ryan if he can start the work earlier. 

> Move the BatchAccumulator in KafkaRaftClient to LeaderState
> -----------------------------------------------------------
>
>                 Key: KAFKA-12265
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12265
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jose Armando Garcia Sancio
>            Assignee: Rohit Deshpande
>            Priority: Major
>
> The {{KafkaRaftClient}} has a field for the {{BatchAccumulator}} that is only used and set when it is the leader. In other cases, leader specific information was stored in {{LeaderState}}. In a recent change {{EpochState}}, which {{LeaderState}} implements, was changed to be a {{Closable}}. {{QuorumState}} makes sure to always close the previous state before transitioning to the next state. We can use this redesign to move the {{BatchAccumulator}} to the {{LeaderState}} and simplify some of the handling in {{KafkaRaftClient}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)