You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/04/16 17:51:11 UTC

[GitHub] [flink] XComp opened a new pull request, #22404: [WIP][FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

XComp opened a new pull request, #22404:
URL: https://github.com/apache/flink/pull/22404

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1568751395

   Rebased PR to master after FLINK-31785 was merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1549943097

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1591050438

   Force pushed formatting fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22404:
URL: https://github.com/apache/flink/pull/22404#discussion_r1201787892


##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java:
##########
@@ -240,13 +241,13 @@ public CompletableFuture<Void> globalCleanupAsync(JobID jobID, Executor executor
                 executor);
     }
 
-    private LeaderElectionService createLeaderElectionService(String leaderName) throws Exception {
+    private LeaderElection createLeaderElectionService(String leaderName) throws Exception {

Review Comment:
   rename to `createLeaderElection`? Although it does a bit more...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1550869231

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22404: [WIP][FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1510444572

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9ddb4ba7c1a9e53ce12e5922a044701ad9f4cce4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9ddb4ba7c1a9e53ce12e5922a044701ad9f4cce4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9ddb4ba7c1a9e53ce12e5922a044701ad9f4cce4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1560672667

   I rebased the PR onto FLINK-31785 (PR #22390 ) and renamed the method in accordance to the review comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1591051518

   rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22404:
URL: https://github.com/apache/flink/pull/22404#discussion_r1221649459


##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingContender.java:
##########
@@ -31,22 +31,17 @@ public class TestingContender extends TestingLeaderBase implements LeaderContend
     private static final Logger LOG = LoggerFactory.getLogger(TestingContender.class);
 
     private final String address;
-    private final LeaderElectionService leaderElectionService;
     private LeaderElection leaderElection;

Review Comment:
   final?



##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java:
##########
@@ -82,7 +81,6 @@ public class JobMasterServiceLeadershipRunner implements JobManagerRunner, Leade
 
     private final JobMasterServiceProcessFactory jobMasterServiceProcessFactory;
 
-    private final LeaderElectionService leaderElectionService;
     private LeaderElection leaderElection;

Review Comment:
   final?



##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherCleanupITCase.java:
##########
@@ -157,10 +157,9 @@ public void testCleanupThroughRetries() throws Exception {
         jobGraphStore.start(NoOpJobGraphListener.INSTANCE);
         haServices.setJobGraphStore(jobGraphStore);
 
-        // Construct leader election service.
-        final TestingLeaderElectionService leaderElectionService =
-                new TestingLeaderElectionService();
-        haServices.setJobMasterLeaderElectionService(jobId, leaderElectionService);
+        // Construct leader election.
+        final TestingLeaderElection leaderElection = new TestingLeaderElection();
+        haServices.setJobMasterLeaderElectionService(jobId, leaderElection);

Review Comment:
   should the method name be updated?



##########
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/TestingHighAvailabilityServices.java:
##########
@@ -49,20 +49,20 @@ public class TestingHighAvailabilityServices implements HighAvailabilityServices
     private volatile Function<JobID, LeaderRetrievalService> jobMasterLeaderRetrieverFunction =
             ignored -> null;
 
-    private volatile Function<JobID, LeaderElectionService> jobMasterLeaderElectionServiceFunction =
+    private volatile Function<JobID, LeaderElection> jobMasterLeaderElectionServiceFunction =
             ignored -> null;
 
     private ConcurrentHashMap<JobID, LeaderRetrievalService> jobMasterLeaderRetrievers =
             new ConcurrentHashMap<>();
 
-    private ConcurrentHashMap<JobID, LeaderElectionService> jobManagerLeaderElectionServices =
+    private ConcurrentHashMap<JobID, LeaderElection> jobManagerLeaderElectionServices =

Review Comment:
   rename field and setter



##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElection.java:
##########
@@ -99,6 +95,10 @@ public synchronized void close() {
         startFuture = new CompletableFuture<>();
     }
 
+    private boolean hasLeadership() {

Review Comment:
   why is this being moved?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1549816346

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #22404:
URL: https://github.com/apache/flink/pull/22404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22404:
URL: https://github.com/apache/flink/pull/22404#issuecomment-1568385377

   I rebased the PR onto most-recent version of the parent PR #22390 (FLINK-31785)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org