You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/28 23:45:49 UTC
[GitHub] codecov-io commented on issue #3895: Fix the RecordReader to pick
incoming time column
codecov-io commented on issue #3895: Fix the RecordReader to pick incoming time column
URL: https://github.com/apache/incubator-pinot/pull/3895#issuecomment-468485205
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=h1) Report
> Merging [#3895](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4964f91d43647031d192b1b34d52af4ddbd87ec1?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `89.62%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3895 +/- ##
============================================
- Coverage 67.31% 67.19% -0.12%
Complexity 4 4
============================================
Files 1032 1032
Lines 50865 50931 +66
Branches 7105 7125 +20
============================================
- Hits 34238 34223 -15
- Misses 14292 14371 +79
- Partials 2335 2337 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/pinot/core/data/readers/RecordReaderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyRmFjdG9yeS5qYXZh) | `42.85% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/core/data/readers/JSONRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvSlNPTlJlY29yZFJlYWRlci5qYXZh) | `93.61% <100%> (+2.7%)` | `0 <0> (ø)` | :arrow_down: |
| [...che/pinot/core/data/readers/RecordReaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyVXRpbHMuamF2YQ==) | `74.07% <100%> (+4.84%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/core/data/readers/AvroRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQXZyb1JlY29yZFJlYWRlci5qYXZh) | `82.25% <80%> (+4.2%)` | `0 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/pinot/core/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0F2cm9VdGlscy5qYXZh) | `56.61% <88.88%> (+3.72%)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/core/data/readers/CSVRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQ1NWUmVjb3JkUmVhZGVyLmphdmE=) | `76.92% <95%> (+8.29%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-59.43%)` | `0% <0%> (ø)` | |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `26.74% <0%> (-39.54%)` | `0% <0%> (ø)` | |
| [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `82.22% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=footer). Last update [4964f91...da22f6f](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org