You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 04:28:41 UTC
[jira] [Commented] (BEAM-1672) Extract interface MetricData
[ https://issues.apache.org/jira/browse/BEAM-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967106#comment-15967106 ]
ASF GitHub Bot commented on BEAM-1672:
--------------------------------------
GitHub user aviemzur opened a pull request:
https://github.com/apache/beam/pull/2522
[BEAM-1672] Extract interface MetricData
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aviemzur/beam metricdata-interface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2522
----
commit aa41c2cbe28797686a34eb47c26502953c86b462
Author: Aviem Zur <av...@gmail.com>
Date: 2017-04-09T19:41:12Z
[BEAM-1672] Extract interface MetricData
----
> Extract interface MetricData
> ----------------------------
>
> Key: BEAM-1672
> URL: https://issues.apache.org/jira/browse/BEAM-1672
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Aviem Zur
> Assignee: Aviem Zur
>
> Extract interface {{MetricData}} with common functionality in {{DistributionData}} and {{GaugeData}}. Create a similar {{CounterData}} class.
> Try to refactor code which uses these methods to use the common interface (without compromising performance).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)