You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by persiaAziz <gi...@git.apache.org> on 2017/03/24 20:07:00 UTC
[GitHub] trafficserver pull request #1606: require sphinx version 1.5.1
GitHub user persiaAziz opened a pull request:
https://github.com/apache/trafficserver/pull/1606
require sphinx version 1.5.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/persiaAziz/trafficserver sphinxReq
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1606
----
commit b85a05dcd2dbd755bc97a4425ea1063a4851a3fc
Author: Persia Aziz <pe...@yahoo-inc.com>
Date: 2017-03-24T20:06:23Z
require sphinx version 1.5.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1606: require sphinx version 1.5.1
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1606#discussion_r107989978
--- Diff: doc/checkvers.py ---
@@ -28,9 +28,9 @@
# Check whether we have a recent version of sphinx. EPEL and CentOS are completely crazy and I don't understand their
# packaging at all. The test below works on Ubuntu and places where sphinx is installed sanely AFAICT.
if options.checkvers:
- print 'checking for sphinx version >= 1.2... ',
- # Need at least 1.2 because of some command line options stuff HRP added.
- # Also 1.2 guarantees sphinx.version_info is available.
+ print 'checking for sphinx version >= 1.5.1... ',
+ # Need at least 1.5.1 to use svg
+ # Also 1.5.1 guarantees sphinx.version_info is available.
--- End diff --
I think you made this comment inaccurate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/101/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1606: require sphinx version 1.5.1
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1606#discussion_r107993671
--- Diff: doc/checkvers.py ---
@@ -28,9 +28,9 @@
# Check whether we have a recent version of sphinx. EPEL and CentOS are completely crazy and I don't understand their
# packaging at all. The test below works on Ubuntu and places where sphinx is installed sanely AFAICT.
if options.checkvers:
- print 'checking for sphinx version >= 1.2... ',
- # Need at least 1.2 because of some command line options stuff HRP added.
- # Also 1.2 guarantees sphinx.version_info is available.
+ print 'checking for sphinx version >= 1.5.1... ',
+ # Need at least 1.5.1 to use svg
+ # Also 1.5.1 guarantees sphinx.version_info is available.
--- End diff --
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/98/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1689/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/360/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/227/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/228/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1690/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/116/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/359/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1798/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/115/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Why was this merged without setting appropriate labels / versions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/99/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1606: require sphinx version 1.5.1
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1606
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1797/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Thanks, @persiaAziz.
This closes #1497 - require a sufficient version of Sphinx Docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1606
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/102/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---