You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2016/12/05 05:35:08 UTC

[GitHub] zeppelin pull request #1727: [ZEPPELIN-1695] Use shared versions in test lib...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/1727

    [ZEPPELIN-1695] Use shared versions in test libraries (maven)

    ### What is this PR for?
    
    Use shared test library versions in maven config so that version fragment doesn't be fragmented. 
    Previously we used multiple versions of 
    
    - Junit (4.11, 4.12)
    - mockito (1.9.0, 1.10.8, ...)
    - powermock (...)
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    
    [ZEPPELIN-1695](https://issues.apache.org/jira/browse/ZEPPELIN-1695)
    
    ### How should this be tested?
    
    Use this command to see test libraries share versions or not
    
    ```
    $ mvn org.apache.maven.plugins:maven-help-plugin:2.2:effective-pom | vim -
    ```
    
    ### Questions:
    * Does the licenses files need update? - YES, I updated JUnit version to 4.12 from 4.11
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin feat/centralise-testing-libraries

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1727
    
----
commit 99f6399d9a4594fecfdf6ec91d1fdc82c3b0f74e
Author: 1ambda <1a...@gmail.com>
Date:   2016-12-05T04:16:05Z

    chore: Update junit to 4.12

commit 0a70337084c2a2701c0810f85d8bd65029adc459
Author: 1ambda <1a...@gmail.com>
Date:   2016-12-05T04:34:09Z

    chore: Shared mockito, powermock version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1727: [ZEPPELIN-1695] Use shared versions in test lib...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1727


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1727
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1727
  
    Looks great to me, thank you @1ambda for valuable build improvements!
    
    Merging to master if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/1727
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---