You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/11 04:46:41 UTC
Review Request 54637: Fixed EOF bug when tty is enabled in switch
board server.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Kevin Klues.
Repository: mesos
Description
-------
stdin fd should only be closed when a tty is not attached.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c
Diff: https://reviews.apache.org/r/54637/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch
board server.
Posted by Vinod Kone <vi...@gmail.com>.
> On Dec. 12, 2016, 2:20 a.m., Kevin Klues wrote:
> > Do we know why the build failed?
rebase issue.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158816
-----------------------------------------------------------
On Dec. 11, 2016, 4:46 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54637/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2016, 4:46 a.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> stdin fd should only be closed when a tty is not attached.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c
>
> Diff: https://reviews.apache.org/r/54637/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch
board server.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158816
-----------------------------------------------------------
Ship it!
Do we know why the build failed?
- Kevin Klues
On Dec. 11, 2016, 4:46 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54637/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2016, 4:46 a.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> stdin fd should only be closed when a tty is not attached.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c
>
> Diff: https://reviews.apache.org/r/54637/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch
board server.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158820
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 11, 2016, 4:46 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54637/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2016, 4:46 a.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> stdin fd should only be closed when a tty is not attached.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c
>
> Diff: https://reviews.apache.org/r/54637/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch
board server.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158799
-----------------------------------------------------------
Bad patch!
Reviews applied: [54637, 54620]
Failed command: ./support/apply-review.sh -n -r 54620
Error:
2016-12-11 15:01:21 URL:https://reviews.apache.org/r/54620/diff/raw/ [11532/11532] -> "54620.patch" [1]
error: patch failed: src/tests/api_tests.cpp:4218
error: src/tests/api_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/16411/console
- Mesos ReviewBot
On Dec. 11, 2016, 4:46 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54637/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2016, 4:46 a.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> stdin fd should only be closed when a tty is not attached.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c
>
> Diff: https://reviews.apache.org/r/54637/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>