You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/03 07:48:34 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #5270: server: skip zone check for PERHOST iso during attachIso

shwstppr opened a new pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270


   ### Description
   
   Hypervisor tools ISO - vmware-toools.iso, xs-tools.iso are marked as PERHOST in DB. They are active but not downloaded to the secondary storages and hence no template-zone entry.
   Skips the template-zone check for such templates.
   
   Fixes #5265
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   Error on attach ISO:
   ![Screenshot from 2021-08-03 13-17-17](https://user-images.githubusercontent.com/153340/127978047-9ce24132-6a35-48bb-b4ef-e28c3291dddd.png)
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891620575


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894897922


   <b>Trillian test result (tid-1536)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46483 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1536-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 355.93 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 591.78 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 582.99 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 501.56 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 538.73 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894784340


   @shwstppr unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892093983


   cmk output added for tests using VMware env attaching vmware-tools ISO to a VM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892471271


   <b>Trillian test result (tid-1465)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41668 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1465-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 303.60 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 522.54 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 480.58 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3787.30 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894664820


   <b>Trillian test result (tid-1524)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38195 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1524-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Smoke tests completed. 84 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 93.93 | test_affinity_groups_projects.py
   test_DeployVmAntiAffinityGroup | `Error` | 47.73 | test_affinity_groups.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 38.09 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892569852






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891621331






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#discussion_r684138414



##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -300,6 +300,9 @@
     @Inject
     private EndPointSelector selector;
 
+    private final static String VMWARE_TOOLS_ISO = "vmware-tools.iso";

Review comment:
       @nvazquez done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#discussion_r681852199



##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -1204,10 +1207,11 @@ public boolean attachIso(long isoId, long vmId, boolean forced) {
             throw new InvalidParameterValueException("Unable to find an ISO with id " + isoId);
         }
 
-        long dcId = vm.getDataCenterId();
-        VMTemplateZoneVO exists = _tmpltZoneDao.findByZoneTemplate(dcId, isoId);
-        if (null == exists) {
-            throw new InvalidParameterValueException("ISO is not available in the zone the VM is in.");
+        if (TemplateType.PERHOST.equals(iso.getTemplateType())) {

Review comment:
       if it was PERHOST we were not going to check, right? looks reversed here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894092319


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892569852


   @sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891620575


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894598273


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891641661


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894316808


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891619180


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891619180


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894784677


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891619317


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891959025


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-893199771


   <b>Trillian test result (tid-1477)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 67163 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1477-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_disk_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 71 look OK, 16 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 2762.37 | test_accounts.py
   test_DeleteDomain | `Error` | 3611.34 | test_accounts.py
   test_DeleteDomain | `Error` | 3617.03 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 3608.59 | test_accounts.py
   test_forceDeleteDomain | `Error` | 3616.12 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 3606.02 | test_accounts.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 2.25 | test_affinity_groups_projects.py
   test_DeployVmAffinityGroup | `Error` | 1.21 | test_affinity_groups.py
   test_DeployVmAntiAffinityGroup | `Error` | 1.13 | test_affinity_groups.py
   test_query_async_job_result | `Error` | 2.64 | test_async_job.py
   test_3d_gpu_support | `Error` | 17.02 | test_deploy_vgpu_enabled_vm.py
   test_05_deploy_vm_with_extraconfig_vmware | `Error` | 1.18 | test_deploy_vm_extra_config_data.py
   test_deploy_vm_from_iso | `Error` | 6.63 | test_deploy_vm_iso.py
   test_00_deploy_vm_root_resize | `Error` | 1.20 | test_deploy_vm_root_resize.py
   test_deployvm_firstfit | `Error` | 1.23 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | `Error` | 1.17 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdispersing | `Error` | 1.16 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdata | `Error` | 1.25 | test_deploy_vm_with_userdata.py
   test_deployvm_userdata_post | `Error` | 1.27 | test_deploy_vm_with_userdata.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_03_deploy_vm_domain_service_offering | `Error` | 1.94 | test_domain_service_offerings.py
   test_03_create_vpc_domain_vpc_offering | `Error` | 4.00 | test_domain_vpc_offerings.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 422.86 | test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 222.32 | test_internal_lb.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 600.29 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 641.32 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 531.61 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 564.67 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 5.44 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Failure` | 3.45 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891621331


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894130711


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian. SL-JID 780


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894317213


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-893035898


   <b>Trillian test result (tid-1476)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41616 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1476-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 82.16 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-893141284


   <b>Trillian test result (tid-1475)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 57917 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1475-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 83 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 833.59 | test_internal_lb.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 519.93 | test_privategw_acl.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 575.62 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 496.64 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 495.68 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 532.75 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1514.41 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892569629


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892142640


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr closed pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894331695


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 787


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891619317


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#discussion_r681887859



##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -1204,10 +1207,11 @@ public boolean attachIso(long isoId, long vmId, boolean forced) {
             throw new InvalidParameterValueException("Unable to find an ISO with id " + isoId);
         }
 
-        long dcId = vm.getDataCenterId();
-        VMTemplateZoneVO exists = _tmpltZoneDao.findByZoneTemplate(dcId, isoId);
-        if (null == exists) {
-            throw new InvalidParameterValueException("ISO is not available in the zone the VM is in.");
+        if (TemplateType.PERHOST.equals(iso.getTemplateType())) {

Review comment:
       @DaanHoogland thanks. Yeah made mistake




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891959390


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894598357


   @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892143295


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#discussion_r683933246



##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -300,6 +300,9 @@
     @Inject
     private EndPointSelector selector;
 
+    private final static String VMWARE_TOOLS_ISO = "vmware-tools.iso";

Review comment:
       Just an improvement suggestion: I've noticed these ISO names are hardcoded on the Vmware and Xen plugins codebase. What about moving `VMWARE_TOOLS_ISO` and `XS_TOOLS_ISO` to the `TemplateManager` interface and replace the hardcoded ISO names for these values on the `plugins/hypervisor/vmware` and `plugins/hypervisor/xenserver` modules?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894602376


   <b>Trillian Build Failed (tid-1522)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894659559


   <b>Trillian test result (tid-1523)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34812 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1523-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Smoke tests completed. 87 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894784275


   @blueorangutan test centos7 xs71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894784275


   @blueorangutan test centos7 xs71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-891980110


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894784340


   @shwstppr unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892569629


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894092898


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-892496095


   tested ok.
   I merged this pr into #5258 , and confirmed the ISO vmware-tools.iso can be attached to vm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5270: server: skip zone check for PERHOST iso during attachIso

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#issuecomment-894784584


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org