You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/04/21 00:04:15 UTC
Review Request 58597: RANGER-1531: Good coding practice while parsing
XML documents in Ranger -- For master branch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58597/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1531
https://issues.apache.org/jira/browse/RANGER-1531
Repository: ranger
Description
-------
Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java 4647004
agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099
Diff: https://reviews.apache.org/r/58597/diff/1/
Testing
-------
Confirmed all the existing unit tests ran successfully.
Thanks,
Sailaja Polavarapu
Re: Review Request 58597: RANGER-1531: Good coding practice while
parsing XML documents in Ranger -- For master branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On April 21, 2017, 7:58 a.m., Colm O hEigeartaigh wrote:
> > Hi, I have already raised a review request for this, but no-one has bothered to review it!
> >
> > https://reviews.apache.org/r/57421/
I've merged a fix for 57421 after a review by Don. So this issue can be marked as resolved.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58597/#review172597
-----------------------------------------------------------
On April 21, 2017, 12:04 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58597/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 12:04 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1531
> https://issues.apache.org/jira/browse/RANGER-1531
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java 4647004
> agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099
>
>
> Diff: https://reviews.apache.org/r/58597/diff/1/
>
>
> Testing
> -------
>
> Confirmed all the existing unit tests ran successfully.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 58597: RANGER-1531: Good coding practice while
parsing XML documents in Ranger -- For master branch
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
> On April 21, 2017, 7:58 a.m., Colm O hEigeartaigh wrote:
> > Hi, I have already raised a review request for this, but no-one has bothered to review it!
> >
> > https://reviews.apache.org/r/57421/
>
> Colm O hEigeartaigh wrote:
> I've merged a fix for 57421 after a review by Don. So this issue can be marked as resolved.
Hi Colm,
Thanks for letting me know and updating the bug as well.
- Sailaja
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58597/#review172597
-----------------------------------------------------------
On April 21, 2017, 12:04 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58597/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 12:04 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1531
> https://issues.apache.org/jira/browse/RANGER-1531
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java 4647004
> agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099
>
>
> Diff: https://reviews.apache.org/r/58597/diff/1/
>
>
> Testing
> -------
>
> Confirmed all the existing unit tests ran successfully.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 58597: RANGER-1531: Good coding practice while
parsing XML documents in Ranger -- For master branch
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58597/#review172597
-----------------------------------------------------------
Hi, I have already raised a review request for this, but no-one has bothered to review it!
https://reviews.apache.org/r/57421/
- Colm O hEigeartaigh
On April 21, 2017, 12:04 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58597/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 12:04 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1531
> https://issues.apache.org/jira/browse/RANGER-1531
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added code to set "FEATURE_SECURE_PROCESSING" property to true for both XML document factory as well as for Transformer Factory.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java 4647004
> agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099
>
>
> Diff: https://reviews.apache.org/r/58597/diff/1/
>
>
> Testing
> -------
>
> Confirmed all the existing unit tests ran successfully.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>