[jira] [Commented] (GIRAPH-375) Cleaner MutableVertex API

["Avery Ching (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477425#comment-13477425 ] 

Avery Ching commented on GIRAPH-375:
------------------------------------

Looks good, I would make one change

I would implement 

public void addVertexRequest(I id, V value) throws IOException
using 
public void addVertexRequest(I id, V value, Map<I, E> edges)

to reduce code duplication.
                
> Cleaner MutableVertex API
> -------------------------
>
>                 Key: GIRAPH-375
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-375
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-375.patch
>
>
> Currently, MutableVertex requires the user to instantiate a vertex before creating the request.
> Using instantiateVertex() also requires a downcast to MutableVertex.
> What we can do instead is pass id and value (and optionally edges) to addVertexRequest(), and the instantiation/initialization will happen internally and safely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira