You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/05/07 06:47:00 UTC

Re: Review Request 17720: OOZIE-1678 HA support for SLA

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/
-----------------------------------------------------------

(Updated May 7, 2014, 4:46 a.m.)


Review request for oozie.


Changes
-------

fixed review comments


Bugs: OOZIE-1678
    https://issues.apache.org/jira/browse/OOZIE-1678


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1678


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a 
  core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
  core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
  core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
  core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
  core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
  core/src/test/resources/coord-action-sla.xml e88df6c 

Diff: https://reviews.apache.org/r/17720/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.


> On May 13, 2014, 12:44 a.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 374
> > <https://reviews.apache.org/r/17720/diff/8/?file=575969#file575969line374>
> >
> >     what happens if multipleServerRunning() gets called by server A when it's the only server, so it returns false; but then server B comes up immediately after?  Will this race condition be a problem?

good point, I thought about it, race condition is less likely happen since time window for contention is very short. Suppose server A starts updateJobSla for particular job id, soon after, server B comes up and registered to ZK. but then server B start SLAService which call loadOnRestart where loading summary beans from DB first, process one by one, then finally trying to update DB (Summary bean) for each job id. until that time, server A should have done with updateJobSla() for one job. (then after server B registered to ZK, both server start to respect lock)


> On May 13, 2014, 12:44 a.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 482
> > <https://reviews.apache.org/r/17720/diff/8/?file=575969#file575969line482>
> >
> >     Instead of doing "instanceof", you can put "multipleServerRunning()" in JobsConcurrencyService which simply always returns "false".  ZKJobsConcurrencyService would override that method (don't forget the "@Override") to actually check with ZooKeeper.

fixed this part. thanks


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review42795
-----------------------------------------------------------


On May 7, 2014, 4:46 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 4:46 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml e88df6c 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Robert Kanter <rk...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review42795
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment76711>

    what happens if multipleServerRunning() gets called by server A when it's the only server, so it returns false; but then server B comes up immediately after?  Will this race condition be a problem?



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment76712>

    Instead of doing "instanceof", you can put "multipleServerRunning()" in JobsConcurrencyService which simply always returns "false".  ZKJobsConcurrencyService would override that method (don't forget the "@Override") to actually check with ZooKeeper.  


- Robert Kanter


On May 7, 2014, 4:46 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 4:46 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml e88df6c 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.


> On May 14, 2014, 4:53 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 127
> > <https://reviews.apache.org/r/17720/diff/9/?file=581274#file581274line127>
> >
> >     Shouldn't we be calling slaCalcStatus.acquireLock() instead of calling directly?

because this case, need to get lock when SLACalcStatus not created yet at initialization


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review42969
-----------------------------------------------------------


On May 16, 2014, 11:46 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 11:46 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml e88df6c 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review42969
-----------------------------------------------------------


Doesn't handle case of removing from historySet. Similar to HCat HA we need a thread running once in a day (1 day is good enough as it is going to be occupying very less memory) and removing entries from historySet if job is already completed.


core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java
<https://reviews.apache.org/r/17720/#comment76940>

    Delete SLARegistrationGetJPAExecutor and SLARegistrationGetonRestartJPAExecutor



core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java
<https://reviews.apache.org/r/17720/#comment76941>

    Can we call this method getSingleValue() and add it to QueryExecutor (implementation that throws UnSupportedException instead of abstract) and override here. There are some jpaexecutors (For eg: count of CoordinatorActionBean)  which return count and this method can be used in common for that. 



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment76944>

    As mentioned in earlier comment lock is not required for non HA mode. It will introduce unnecessary latency. 
    
    If you want to keep code simple return a static DummyLockToken object which has empty implementation for release()
    
    if (!JobsConcurrencyService. multipleServerRunning()) {
      lock = DUMMY_LOCKTOKEN;
    }



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment76942>

    Empty line between methods



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment76945>

    Shouldn't we be calling slaCalcStatus.acquireLock() instead of calling directly?



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment76943>

    Do not have to catch exception at all and throw them again. Remove the catch blocks.



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment76947>

    Keep this logic in SLACalcStatus



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment76948>

    Why queue event when there is no expected start? Accidental change?



core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java
<https://reviews.apache.org/r/17720/#comment76946>

    When is apptype null?



core/src/test/java/org/apache/oozie/service/TestHASLAService.java
<https://reviews.apache.org/r/17720/#comment76950>

    We need to have test cases where two instances are started with lot of entries loaded on start and actions performed alternatively on one another and check if other reflects the change on updateAllSlaStatus() to actually test code path while both servers are running.



core/src/test/java/org/apache/oozie/service/TestHASLAService.java
<https://reviews.apache.org/r/17720/#comment76949>

    Test is redundant and can be removed as load on restart has nothing changed between HA and normal case and does not test anything new.



core/src/test/java/org/apache/oozie/service/TestHASLAService.java
<https://reviews.apache.org/r/17720/#comment76951>

    This test also does not exercise HA code path without ZKJobsConcurrencyService. This test is just equivalent to having one server in non-HA mode restarted. 


- Rohini Palaniswamy


On May 14, 2014, 2:26 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 2:26 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml e88df6c 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Rohini Palaniswamy <ro...@gmail.com>.


> On May 19, 2014, 10:44 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java, line 413
> > <https://reviews.apache.org/r/17720/diff/10/?file=583836#file583836line413>
> >
> >     throw new UnSupportedOperationException(). 
> >     
> >     Add this method to QueryExecutor itself and remove empty overriding in each class.

Comment not addressed. Please mark issues as resolved or dropped. This will help track addressed review comments.


- Rohini


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review43431
-----------------------------------------------------------


On May 31, 2014, 12:26 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 12:26 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review43431
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment77573>

    protected



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment77581>

    Make it "else if" instead of nesting if inside else block



core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java
<https://reviews.apache.org/r/17720/#comment77568>

    throw new UnSupportedOperationException(). 
    
    Add this method to QueryExecutor itself and remove empty overriding in each class.



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment77569>

    getEntityKey() will never be null



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment77571>

    Move this inside if (multipleServerRunning) block.



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment77572>

    private static



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment77576>

    Use an iterator and do iter.remove()



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment77578>

    Just removing from historySet is not enough. Need to update the start, end, duration based on the completion times.



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment77579>

    Put the try catch inside the loop, so that even if there is an error for one we iterate over others.



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment77580>

    multipleServerRunning still not handled here



core/src/test/java/org/apache/oozie/service/TestHASLAService.java
<https://reviews.apache.org/r/17720/#comment77583>

    private



core/src/test/java/org/apache/oozie/service/TestHASLAService.java
<https://reviews.apache.org/r/17720/#comment77584>

    Should not be the case. A completed action should not be in history set.


- Rohini Palaniswamy


On May 16, 2014, 11:46 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 11:46 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml e88df6c 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review45168
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment79876>

    private static



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment79870>

    if bean == null, bean.getId will throw error. Same in other places as well.



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment79872>

    event processed needs to be set to 8. Also actual start time also needs to be updated



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment79873>

    To be removed


- Rohini Palaniswamy


On May 31, 2014, 12:26 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 12:26 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.


> On June 16, 2014, 5:59 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java, line 139
> > <https://reviews.apache.org/r/17720/diff/13/?file=608483#file608483line139>
> >
> >     This can be removed and the similar method you added for the HCat+HA patch can be used instead.

actually both introduced for different purposes. isHighlyAvailableMode() indicate whether server starts in HA mode or not (ZKJobsConcurrency used or not),  MultipleServerRunning indicate whether # of servers running > 1 or not at each moment (even in HA mode).  in HCat, we enable dependency table purge when start in HA mode (regardless of # of servers) thus, using isHighlyAvailableMode().   in SLA, even in HA mode, when only one server is running, we avoid using zk lock, thus using MultipleServerRunning(). so I believe both needed.


> On June 16, 2014, 5:59 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java, line 290
> > <https://reviews.apache.org/r/17720/diff/13/?file=608485#file608485line290>
> >
> >     What happens if multiple threads in the same Oozie server try to call acquireLock(), isLocked(), and/or releaseLock() concurrently?

yes, to that end, we do synchronized (slaCalc) before occurence of slaCalc.acquireLock(). let me check again if there is no overlook


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review45770
-----------------------------------------------------------


On June 13, 2014, 7:49 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 436b999 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java cddeaf7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 86c2d32 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 9e0f03b 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.


> On June 16, 2014, 5:59 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java, line 139
> > <https://reviews.apache.org/r/17720/diff/13/?file=608483#file608483line139>
> >
> >     This can be removed and the similar method you added for the HCat+HA patch can be used instead.
> 
> Ryota Egashira wrote:
>     actually both introduced for different purposes. isHighlyAvailableMode() indicate whether server starts in HA mode or not (ZKJobsConcurrency used or not),  MultipleServerRunning indicate whether # of servers running > 1 or not at each moment (even in HA mode).  in HCat, we enable dependency table purge when start in HA mode (regardless of # of servers) thus, using isHighlyAvailableMode().   in SLA, even in HA mode, when only one server is running, we avoid using zk lock, thus using MultipleServerRunning(). so I believe both needed.

revisited this point and discussed. supposing in most cases, when runing in HA mode, multiple servers are running. so we changed MultipleServerRunning -> isHighlyAvailableMode as suggested, thanks


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review45770
-----------------------------------------------------------


On June 13, 2014, 7:49 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 436b999 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java cddeaf7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 86c2d32 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 9e0f03b 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Robert Kanter <rk...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review45770
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java
<https://reviews.apache.org/r/17720/#comment80749>

    This can be removed and the similar method you added for the HCat+HA patch can be used instead.



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment80750>

    What happens if multiple threads in the same Oozie server try to call acquireLock(), isLocked(), and/or releaseLock() concurrently?


- Robert Kanter


On June 13, 2014, 7:49 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 436b999 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java cddeaf7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 86c2d32 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 9e0f03b 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Rohini Palaniswamy <ro...@gmail.com>.


> On June 17, 2014, 10:38 p.m., Rohini Palaniswamy wrote:
> > Ship It!

multipleServerRunning -> isHighlyAvailableMode() as Robert suggested please.


- Rohini


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review46001
-----------------------------------------------------------


On June 13, 2014, 7:49 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 436b999 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java cddeaf7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 86c2d32 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 9e0f03b 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review46001
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On June 13, 2014, 7:49 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 436b999 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java cddeaf7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 86c2d32 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 9e0f03b 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/
-----------------------------------------------------------

(Updated June 13, 2014, 7:49 a.m.)


Review request for oozie.


Changes
-------

revised version


Bugs: OOZIE-1678
    https://issues.apache.org/jira/browse/OOZIE-1678


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1678


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 436b999 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java cddeaf7 
  core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
  core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
  core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
  core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
  core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
  core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 86c2d32 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
  core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 9e0f03b 
  core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
  core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
  core/src/test/resources/coord-action-sla.xml 4893c61 

Diff: https://reviews.apache.org/r/17720/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/
-----------------------------------------------------------

(Updated June 11, 2014, 8:59 a.m.)


Review request for oozie.


Changes
-------

fixed review comments


Bugs: OOZIE-1678
    https://issues.apache.org/jira/browse/OOZIE-1678


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1678


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
  core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
  core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
  core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
  core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
  core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
  core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
  core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
  core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
  core/src/test/resources/coord-action-sla.xml 4893c61 

Diff: https://reviews.apache.org/r/17720/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/
-----------------------------------------------------------

(Updated May 31, 2014, 12:26 a.m.)


Review request for oozie.


Changes
-------

fixed review comments


Bugs: OOZIE-1678
    https://issues.apache.org/jira/browse/OOZIE-1678


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1678


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
  core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
  core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
  core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
  core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
  core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
  core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
  core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
  core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
  core/src/test/resources/coord-action-sla.xml 4893c61 

Diff: https://reviews.apache.org/r/17720/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/
-----------------------------------------------------------

(Updated May 16, 2014, 11:46 p.m.)


Review request for oozie.


Changes
-------

revised version based on comments.


Bugs: OOZIE-1678
    https://issues.apache.org/jira/browse/OOZIE-1678


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1678


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
  core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
  core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
  core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
  core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
  core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
  core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
  core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
  core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
  core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
  core/src/test/resources/coord-action-sla.xml e88df6c 

Diff: https://reviews.apache.org/r/17720/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 17720: OOZIE-1678 HA support for SLA

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/
-----------------------------------------------------------

(Updated May 14, 2014, 2:26 a.m.)


Review request for oozie.


Changes
-------

review comments fixed.


Bugs: OOZIE-1678
    https://issues.apache.org/jira/browse/OOZIE-1678


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1678


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a 
  core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
  core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
  core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
  core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java ea2983f 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
  core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
  core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
  core/src/test/resources/coord-action-sla.xml e88df6c 

Diff: https://reviews.apache.org/r/17720/diff/


Testing
-------


Thanks,

Ryota Egashira