You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/31 16:21:04 UTC

[GitHub] [apisix] membphis commented on pull request #2121: bugfix: updated the value of remaining when `count` changes in limit-count plugin.

membphis commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683882604


   > #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1635.
   > #                   '2020-08-31_10-25-32__access.log
   > # 2020-08-31_10-25-31__access.log
   > # 2020-08-31_10-25-33__access.log
   > # .
   > # 2020-08-31_10-25-32__error.log
   > # error.log
   > # 2020-08-31_10-25-33__error.log
   > # access.log
   > # 2020-08-31_10-25-31__error.log
   > # ..
   > # nginx.pid
   > # '
   > #     doesn't match '(?^:\_error\.log[\s\S]*\_access\.log)'
   > # Looks like you failed 1 test of 7.
   > t/plugin/log-rotate.t .................... 
   > ```
   
   we need to update this test case.  will create a new issue later


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org