[GitHub] [cloudstack-go] mlsorensen commented on pull request #46: Generate account details correctly (accountdetails[0].somekey=someval)

["mlsorensen (via GitHub)" <gi...@apache.org>]

mlsorensen commented on PR #46:
URL: https://github.com/apache/cloudstack-go/pull/46#issuecomment-1454452929

   > @mlsorensen one remark - could this cause backward compatibility issue (in case other users/clients are passing details with the old format, for example looking at cmk docs - https://github.com/apache/cloudstack-cloudmonkey/wiki/Usage#argument-passing)
   
   Hmm, I'm not sure. I can only say that passing it the way it has now doesn't actually work.  This PR I think actually moves it to work in accord with the link above where the desired key name is a part of the parameter (left side of "=").
   
   When it currently passes:
   
   ```
   accountdetails[0].key=aaa
   accountdetails[0].value=bbb
   ```
   
   you end up with this in the resulting account:
   
   ```
   "accountdetails": {
       "key": "aaa",
       "value: "bbb"
   }
   ```
   
   Whereas in some other APIs it gets interpreted as:
   
   ```
   "aaa": "bbb"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org